Skip to content

Use ZipArchive in JArchiveZip #31246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2020
Merged

Use ZipArchive in JArchiveZip #31246

merged 3 commits into from
Nov 14, 2020

Conversation

SharkyKZ
Copy link
Contributor

Summary of Changes

zip_* functions are deprecated on PHP 8. Use ZipArchive instead.

Testing Instructions

Test that extracting zip archive using JArchiveZip still works. E.g. use this code:

$zip = new JArchiveZip;
$zip->extract($file, $destination);

Where $file is path to zip archive and $destination is destination directory.

Expected result AFTER applying this Pull Request

Works like before.

Documentation Changes Required

No.

@SharkyKZ SharkyKZ added the PHP 8.x PHP 8.x deprecated issues label Oct 27, 2020
@SharkyKZ SharkyKZ marked this pull request as ready for review October 27, 2020 09:48
@alikon
Copy link
Contributor

alikon commented Nov 7, 2020

@SharkyKZ
Copy link
Contributor Author

SharkyKZ commented Nov 7, 2020

Already done.

@alikon
Copy link
Contributor

alikon commented Nov 7, 2020

@HLeithner
Copy link
Member

I tested the Zip Archive in our framework (which uses the same code) successfully.

Thanks

@HLeithner HLeithner merged commit a13a289 into joomla:staging Nov 14, 2020
@HLeithner HLeithner added this to the Joomla! 3.9.23 milestone Nov 14, 2020
@SharkyKZ SharkyKZ deleted the j3/php8/zip branch November 14, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants