Use ZipArchive in JArchiveZip #31246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you should do the same fix on https://github.com/joomla/joomla-cms/blob/staging/libraries/vendor/joomla/archive/src/Zip.php too |
|
Already done. |
|
what i'm missing ? |
|
I tested the Zip Archive in our framework (which uses the same code) successfully. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
zip_*functions are deprecated on PHP 8. UseZipArchiveinstead.Testing Instructions
Test that extracting zip archive using
JArchiveZipstill works. E.g. use this code:Where
$fileis path to zip archive and$destinationis destination directory.Expected result AFTER applying this Pull Request
Works like before.
Documentation Changes Required
No.