Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Smart search missing strings #31393

Merged
merged 1 commit into from
Nov 14, 2020
Merged

Conversation

brianteeman
Copy link
Contributor

This fixes the missing strings reported in #30965.

It does not fix the problem causing these error strings to be displayed.

To replicate the error to see that this PR correctly adds the strings.

  1. Install Sample Data
  2. Index content with smart search
  3. Unpublish all content maps
  4. Try to publish all content maps at the same time
    This should produce the plural error message
  5. Try to publish any content map that is not a parent item
    This should produce the singular error message

This fixes the missing strings reported in joomla#30965.

It does not fix the problem causing these error strings to be displayed.

To replicate the error to see that this PR correctly adds the strings.

1. Install Sample Data
2. Index content
3. Unpublish all content maps
4. Try to publish all content maps at the same time
This should produce the plural error message
5. Try to publish any content map that is not a parent item
This should produce the singular error message
@particthistle
Copy link
Member

I have tested this item ✅ successfully on d563ea9

Language strings now appear.

Language strings now appearing makes the issue in #30965 far easier to resolve now.

@ceford
Copy link
Contributor

ceford commented Nov 13, 2020

I have tested this item ✅ successfully on d563ea9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31393.

@infograf768 infograf768 removed Language Change This is for Translators PR-4.0-dev labels Nov 13, 2020
@infograf768
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31393.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 13, 2020
@Quy Quy added the PR-4.0-dev label Nov 13, 2020
@richard67 richard67 merged commit dcd5475 into joomla:4.0-dev Nov 14, 2020
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators and removed RTC This Pull Request is Ready To Commit labels Nov 14, 2020
@richard67
Copy link
Member

Thanks!

@richard67 richard67 added this to the Joomla 4.0 milestone Nov 14, 2020
@brianteeman
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants