Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Uncaught ValueError: Path cannot be empty ..." in com_joomlaupdate restore.php #31442

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Nov 20, 2020

Pull Request for Issue #31308 .

Summary of Changes

Adds a check if the path is empty.

Testing Instructions

See issue #31308 .

To reproduce, update e.g. a 3.9.22 to 3.9.23 RC.

To test the fix of this PR, update e.g. a 3.9.22 to the update package built by Drone for this PR.

Verify that the update has run completely by checking the Joomla Update log file administrator/logs/joomla_update.php. The following logs should be there:

2020-11-20T18:39:21+00:00       INFO 192.168.98.1       update  Update started by user Super User (342). Old version is 3.9.22.
2020-11-20T18:39:21+00:00       INFO 192.168.98.1       update  Downloading update file from https://ci.joomla.org/artifacts/joomla/joomla-cms/staging/31442/downloads/37665/Joomla_3.9.23-rc+pr.31442-Release_Candidate-Update_Package.zip.
2020-11-20T18:39:22+00:00       INFO 192.168.98.1       update  File Joomla_3.9.23-rc+pr.31442-Release_Candidate-Update_Package.zip downloaded.
2020-11-20T18:39:22+00:00       INFO 192.168.98.1       update  Starting installation of new version.
2020-11-20T18:39:25+00:00       INFO 192.168.98.1       update  Finalising installation.
2020-11-20T18:39:25+00:00       INFO 192.168.98.1       update  Deleting removed files and folders.
2020-11-20T18:39:26+00:00       INFO 192.168.98.1       update  Cleaning up after installation.
2020-11-20T18:39:26+00:00       INFO 192.168.98.1       update  Update to version 3.9.23-rc+pr.31442 is complete.

Actual result BEFORE applying this Pull Request

See issue #31308 .

Expected result AFTER applying this Pull Request

No PHP error like described in issue #31308 .

Documentation Changes Required

None.

@richard67 richard67 changed the title Fix empty path in com_joomlaupdate restore.php Fix "Uncaught ValueError: Path cannot be empty ..." in com_joomlaupdate restore.php Nov 20, 2020
@HLeithner HLeithner added the PHP 8.x PHP 8.x deprecated issues label Nov 20, 2020
@alikon
Copy link
Contributor

alikon commented Nov 21, 2020

I have tested this item successfully on d158e60

php 8 rc4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31442.

@laoneo
Copy link
Member

laoneo commented Nov 21, 2020

I have tested this item successfully on d158e60


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31442.

@richard67 richard67 removed PHP 8.x PHP 8.x deprecated issues PR-staging labels Nov 21, 2020
@richard67
Copy link
Member Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31442.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 21, 2020
@richard67 richard67 added PHP 8.x PHP 8.x deprecated issues PR-staging labels Nov 21, 2020
@richard67 richard67 added this to the Joomla! 3.9.23 milestone Nov 21, 2020
@HLeithner HLeithner merged commit ac9e4f9 into joomla:staging Nov 21, 2020
4 checks passed
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 21, 2020
@richard67 richard67 deleted the staging-fix-joomlaupdate-restore-empty-path branch November 21, 2020 15:01
@PhilETaylor

This comment was marked as abuse.

@HLeithner
Copy link
Member

thanks phil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants