Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper string comparison function for tag aliases #31445

Merged
merged 2 commits into from
Nov 21, 2020

Conversation

HLeithner
Copy link
Member

Pull Request for Tags Issue in PHP8

Summary of Changes

Changed arrow comparison function to use strcmp function

Testing Instructions

  1. Open Tags list view
  2. Open Search Tools

Actual result BEFORE applying this Pull Request

Deprecated: usort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero in libraries/joomla/form/fields/aliastag.php on line 67

Expected result AFTER applying this Pull Request

No error

@HLeithner HLeithner added the PHP 8.x PHP 8.x deprecated issues label Nov 20, 2020
@HLeithner HLeithner added this to the Joomla! 3.9.23 milestone Nov 20, 2020
Co-authored-by: Quy <quy@fluxbb.org>
@Quy
Copy link
Contributor

Quy commented Nov 20, 2020

I have tested this item ✅ successfully on 69d1957


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31445.

@bayareajenn
Copy link

I have tested this item 🔴 unsuccessfully on 69d1957

I applied the patch and continued to have the same errors. :(


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31445.

@alikon
Copy link
Contributor

alikon commented Nov 21, 2020

I have tested this item ✅ successfully on 69d1957

php8 rc4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31445.

@richard67
Copy link
Member

I applied the patch and continued to have the same errors. :(

@bayareajenn Really? The Deprecated: usort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero in libraries/joomla/form/fields/aliastag.php on line 67 error when opening the search tools in the tags list view? Have you checked if the patch has been applied correctly, i.e. the file shows the changes which you can see here on GitHub for that file?

@bayareajenn
Copy link

I have tested this item ✅ successfully on 69d1957

My apologies, I tested this and then checked it against a different bug. Indeed this corrects the issue in tags. Thanks Harald.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31445.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 3.9.23 milestone Nov 21, 2020
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31445.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 21, 2020
@bembelimen bembelimen merged commit 9cfe0b5 into joomla:staging Nov 21, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 21, 2020
@HLeithner HLeithner added this to the Joomla! 3.9.23 milestone Nov 21, 2020
@HLeithner HLeithner deleted the php8/tags branch January 9, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 8.x PHP 8.x deprecated issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants