-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proper string comparison function for tag aliases #31445
Conversation
Co-authored-by: Quy <quy@fluxbb.org>
I have tested this item ✅ successfully on 69d1957 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31445. |
I have tested this item 🔴 unsuccessfully on 69d1957 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31445. |
I have tested this item ✅ successfully on 69d1957 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31445. |
@bayareajenn Really? The |
I have tested this item ✅ successfully on 69d1957 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31445. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31445. |
Pull Request for Tags Issue in PHP8
Summary of Changes
Changed arrow comparison function to use strcmp function
Testing Instructions
Actual result BEFORE applying this Pull Request
Deprecated: usort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero in libraries/joomla/form/fields/aliastag.php on line 67
Expected result AFTER applying this Pull Request
No error