make() method for component router interface #3243

wants to merge 18 commits into


None yet
6 participants

Hackwar commented Mar 6, 2014

This PR adds a make() method to the component router interface. This method is meant to clean up URLs and do a kind of pre-processing on them and is thus executed on each URL every time, regardless of SEF being turned on or off.

The specific task for this method is to provide a means to add the Itemid to a URL in the router. Since the component router is normally only loaded when SEF is switched on and then it is only meant to actually SEF the URL, this process needs to go into a second method, which is only aimed at cleaning up the URL and provide a way to add this Itemid.

Of course, we don't have to only add the Itemid here. We might add or remove other parts of the query, which ultimately makes processing the query in the actual build() method easier. Think of missing slug or a timestamp or renaming limitstart to start, etc.

oe1tkt and others added some commits Jan 3, 2014

Invalid attribute width inside <tr> and additionally obsolete attributes
An invalid attribute within <tr> was found. In addition, I removed several attributes which its use is discouraged in HTML5.
Update editor.php
When a bad coded or outdated (i.e.) non-compatible plugin is installed you cannot open the editor and an error is shown "Call to undefined method stdClass::onDisplay() Error". Only 2 fields are visible "Name and Alias". I posted the entire issue on!searchin/joomla-dev-cms/$2Flibraries$2Fcms$2Feditor$2Feditor.php/joomla-dev-cms/-2EPgbbNn78/7LKB3_5Ah8IJ and will post also a Tracker item shortly. 

The code change checks to see if the class method named “onDisplay” exists before attempting to use it but will pass without throwing the error 

Leo Lammerink
Merge pull request #3210 from wilsonge/tinymce
[#33387] Update TinyMCE to 4.0.18
Merge pull request #2752 from oe1tkt/patch-2
Invalid attribute width inside <tr> and additionally obsolete attributes
Merge pull request #3237 from dextercowley/sys-tests-20140304
Fix failing system tests (from Chozen update)

@Hackwar Hackwar closed this Mar 6, 2014

@Hackwar Hackwar deleted the Hackwar:router_interface branch Mar 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment