Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

make() method for component router interface #3243

Closed
wants to merge 18 commits into from

6 participants

@Hackwar

This PR adds a make() method to the component router interface. This method is meant to clean up URLs and do a kind of pre-processing on them and is thus executed on each URL every time, regardless of SEF being turned on or off.

The specific task for this method is to provide a means to add the Itemid to a URL in the router. Since the component router is normally only loaded when SEF is switched on and then it is only meant to actually SEF the URL, this process needs to go into a second method, which is only aimed at cleaning up the URL and provide a way to add this Itemid.

Of course, we don't have to only add the Itemid here. We might add or remove other parts of the query, which ultimately makes processing the query in the actual build() method easier. Think of missing slug or a timestamp or renaming limitstart to start, etc.

oe1tkt and others added some commits
@oe1tkt oe1tkt Invalid attribute width inside <tr> and additionally obsolete attributes
An invalid attribute within <tr> was found. In addition, I removed several attributes which its use is discouraged in HTML5.
59c5171
gwsdesk Update editor.php
When a bad coded or outdated (i.e.) non-compatible plugin is installed you cannot open the editor and an error is shown "Call to undefined method stdClass::onDisplay() Error". Only 2 fields are visible "Name and Alias". I posted the entire issue on https://groups.google.com/forum/#!searchin/joomla-dev-cms/$2Flibraries$2Fcms$2Feditor$2Feditor.php/joomla-dev-cms/-2EPgbbNn78/7LKB3_5Ah8IJ and will post also a Tracker item shortly. 

The code change checks to see if the class method named “onDisplay” exists before attempting to use it but will pass without throwing the error 

Leo Lammerink
MD GWS-Desk.com
ebd7108
@wilsonge wilsonge Update tinymce to 4.0.18 f932d57
@infograf768 infograf768 Updating TinyMCE lang strings: ca, id, sv 8be7b5b
@infograf768 infograf768 Merge remote-tracking branch 'origin/staging' into staging 1fcf67b
@infograf768 infograf768 Updating TinyMCE lang file: sw fac3f9f
@mbabker mbabker Merge pull request #3210 from wilsonge/tinymce
[#33387] Update TinyMCE to 4.0.18
1581e40
@infograf768 infograf768 Updating ja.js TinyMCe lang file 920de73
@infograf768 infograf768 Bootstraps tabs strings not escaped and Wrong sprintf usage (Fix #3203) 5a0cf22
@infograf768 infograf768 Merge pull request #2752 from oe1tkt/patch-2
Invalid attribute width inside <tr> and additionally obsolete attributes
f69bb00
@infograf768 infograf768 Merge pull request #3166 from gwsdesk/patch-1
Update editor.php
d24d32f
@infograf768 infograf768 TinyMCE lang files: updating mk, adding sy ed3ea88
@dextercowley dextercowley Fix failing system tests (from Chozen update) da97dbd
@dextercowley dextercowley Merge pull request #3237 from dextercowley/sys-tests-20140304
Fix failing system tests (from Chozen update)
d69b47c
@dextercowley dextercowley Fix system test problems with Chosen c788939
@dextercowley dextercowley Merge pull request #3241 from dextercowley/sys-test-fixes-20140305
Fix system test problems with Chosen
3673770
@Hackwar Hackwar Merge branch '3.3-dev' of https://github.com/joomla/joomla-cms into r…
…outer_interface
947f365
@Hackwar Hackwar Implementing make() method for routers 1a293f7
@Hackwar Hackwar closed this
@Hackwar Hackwar deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 3, 2014
  1. @oe1tkt

    Invalid attribute width inside <tr> and additionally obsolete attributes

    oe1tkt authored
    An invalid attribute within <tr> was found. In addition, I removed several attributes which its use is discouraged in HTML5.
Commits on Feb 23, 2014
  1. Update editor.php

    gwsdesk authored
    When a bad coded or outdated (i.e.) non-compatible plugin is installed you cannot open the editor and an error is shown "Call to undefined method stdClass::onDisplay() Error". Only 2 fields are visible "Name and Alias". I posted the entire issue on https://groups.google.com/forum/#!searchin/joomla-dev-cms/$2Flibraries$2Fcms$2Feditor$2Feditor.php/joomla-dev-cms/-2EPgbbNn78/7LKB3_5Ah8IJ and will post also a Tracker item shortly. 
    
    The code change checks to see if the class method named “onDisplay” exists before attempting to use it but will pass without throwing the error 
    
    Leo Lammerink
    MD GWS-Desk.com
Commits on Feb 28, 2014
  1. @wilsonge

    Update tinymce to 4.0.18

    wilsonge authored
Commits on Mar 2, 2014
  1. @infograf768
  2. @infograf768
  3. @infograf768
Commits on Mar 3, 2014
  1. @mbabker

    Merge pull request #3210 from wilsonge/tinymce

    mbabker authored
    [#33387] Update TinyMCE to 4.0.18
  2. @infograf768
  3. @infograf768
  4. @infograf768

    Merge pull request #2752 from oe1tkt/patch-2

    infograf768 authored
    Invalid attribute width inside <tr> and additionally obsolete attributes
  5. @infograf768

    Merge pull request #3166 from gwsdesk/patch-1

    infograf768 authored
    Update editor.php
Commits on Mar 4, 2014
  1. @infograf768
  2. @dextercowley
  3. @dextercowley

    Merge pull request #3237 from dextercowley/sys-tests-20140304

    dextercowley authored
    Fix failing system tests (from Chozen update)
Commits on Mar 5, 2014
  1. @dextercowley
  2. @dextercowley

    Merge pull request #3241 from dextercowley/sys-test-fixes-20140305

    dextercowley authored
    Fix system test problems with Chosen
Commits on Mar 6, 2014
  1. @Hackwar
  2. @Hackwar
Something went wrong with that request. Please try again.