Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Save as Copy tag #32454

Merged
merged 2 commits into from Feb 23, 2021
Merged

Conversation

joomdonation
Copy link
Contributor

@joomdonation joomdonation commented Feb 18, 2021

Pull Request for Issue #32407 and #32406.

Summary of Changes

This PR fixes 2 issues as described in #32407 and #32406 :

  • Tag created by Save as Copy should be unpublished
  • When Save as Copy, if Admin changes Title of the tag before saving, Alias of the created tag should be created base on the new title

Testing Instructions

  1. Click on a tag to edit
  2. Press Save as Copy button in the toolbar
  3. Before patch: Tag is published. After patch, tag is unpublished
  1. Click on a tag to edit
  2. Change title of the Tag, press Save as Copy button in the toolbar.
  3. Before patch: Alias is not generated base on the new Title. After patch, alias is generated base on Title.

Co-authored-by: Quy <quy@fluxbb.org>
@Quy
Copy link
Contributor

Quy commented Feb 22, 2021

I have tested this item ✅ successfully on add0ee8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32454.

@Quy
Copy link
Contributor

Quy commented Feb 22, 2021

For test 2 after step 2, do Press Save as Copy button in the toolbar.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on add0ee8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32454.

@infograf768
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32454.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 23, 2021
@infograf768 infograf768 added this to the Joomla! 3.9.25 milestone Feb 23, 2021
@HLeithner HLeithner merged commit 83d3527 into joomla:staging Feb 23, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 23, 2021
@HLeithner
Copy link
Member

Thanks, even if I don't like the unpublishing on save2copy but it's reflect the behavior of most of the other components.

@infograf768
Copy link
Member

I like the unpublished. It lets user check/modify before publishing. 😉

@joomdonation joomdonation deleted the fix_tag_save_as_copy branch February 24, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants