New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5.x] Fixing version comparison for database schema #3251

Merged
merged 5 commits into from Mar 10, 2014

Conversation

Projects
None yet
6 participants
@Hackwar
Member

Hackwar commented Mar 6, 2014

#2147 tried to fix a broken version comparison that was there, but did it in a wrong way. The schema was compared against the Joomla version, although the two have actually very little in common.

$this->schemaVersion is the schema version stored in the database. $this->changeset->getSchema() is the latest available file in the respective folder of com_admin. Those 2 should be compared and not $this->schemaVersion with the Joomla version.

Since before #2147 it only compared the first 5 characters of the schemaVersion and the Joomla version, the check was always positive for all Joomla 2.5.1x versions and it only wanted to update for new Joomla 3.x.x versions, but didn't really react during development time. Introducing the version comparison showed that bug, but didn't really fix it. This PR should do that.

Mea culpa.

@komodore

This comment has been minimized.

komodore commented Mar 7, 2014

In Your patches is error:
is: $this->changeset->getschema()
corrrect is: $this->changeSet->getSchema()

@infograf768

This comment has been minimized.

Member

infograf768 commented Mar 8, 2014

Needs update to Hathor

@wilsonge

This comment has been minimized.

@wilsonge

This comment has been minimized.

Contributor

wilsonge commented Mar 8, 2014

I can't see any override to Hathor needed here

mbabker added a commit that referenced this pull request Mar 10, 2014

Merge pull request #3251 from Hackwar/patch-14
[2.5.x] Fixing version comparison for database schema

@mbabker mbabker merged commit b783377 into joomla:2.5.x Mar 10, 2014

@Hackwar Hackwar deleted the Hackwar:patch-14 branch Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment