Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing validate-uncompressed.js #3303

Closed
wants to merge 2 commits into from
Closed

Fixing validate-uncompressed.js #3303

wants to merge 2 commits into from

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Mar 14, 2014

Fixes #3278

@chivitli
Copy link
Contributor

@chivitli chivitli commented Mar 14, 2014

@test ok here

@phproberto
Copy link
Contributor

@phproberto phproberto commented Mar 14, 2014

If it's going to use jQuery we should embed everything on a:

(function($) {
    // Here code that uses $
})(jQuery);

So you save all the jQuery modifications.

@mbabker
Copy link
Contributor

@mbabker mbabker commented Mar 14, 2014

Can you make sure the compressed file gets updated too please?

On Friday, March 14, 2014, Hannes Papenberg notifications@github.com
wrote:

Fixes #3278 #3278

You can merge this Pull Request by running

git pull https://github.com/Hackwar/joomla-cms validate

Or view, comment on, or merge it at:

#3303
Commit Summary

  • Fixing validate-uncompressed.js

File Changes

  • M media/system/js/validate-uncompressed.jshttps://github.com//pull/3303/files#diff-0(16)

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com//pull/3303
.

@Hackwar
Copy link
Member Author

@Hackwar Hackwar commented Mar 27, 2014

Compressed the file, but its untested. So please beware.

@Bakual
Copy link
Contributor

@Bakual Bakual commented Mar 28, 2014

Test successful both with debug enabled and disabled. Thanks!

Bakual added a commit that referenced this pull request Mar 28, 2014
@Bakual
Copy link
Contributor

@Bakual Bakual commented Mar 28, 2014

Merged

@Bakual Bakual closed this Mar 28, 2014
Bakual added a commit to Bakual/joomla-cms that referenced this pull request May 12, 2014
@Hackwar Hackwar deleted the Hackwar:validate branch Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants