[4.0] Swap layout of buttons in com_media's delete confirmation modal #33221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
YatharthVyas
changed the title
|
I have tested this item ✅ successfully on 04f806f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33221. |
|
With Patch: This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33221. |
ghost
mentioned this pull request
|
I have tested this item ✅ successfully on 04f806f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33221. |
joomla-cms-bot
removed
NPM Resource Changed
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33221. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33221. |
joomla-cms-bot
added
RTC
joomla-cms-bot
added
NPM Resource Changed
|
Thanks! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #33215 .
Summary of Changes
The
deletebutton to the right of thecancelbutton incom_media's delete confirmation modal.The reasoning behind this is better explained in #33215 (comment)
Testing Instructions
npm ciEnsure that the delete button is to the right of cancel and it works as intended.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
None