[4] New moduleposition below-top, option to switch off logo

[chmst]

Summary of Changes

Not all users want it have a logo in the header of their site. Cassipoeia has no option to switch off the display of a logo or description
This PR adds a param to the template where the user can switch off the logo.
It adds a new position "below-top" where users can add an own module.
Using both - position "below-top" and logo is up to the user.

The error page can be adapted if this is accepted.

Testing Instructions

Apply the patch and play with the template style cassiopeia. Use the module position brand

Actual result BEFORE applying this Pull Request

There is always an area for the logo above the navigation.

Expected result AFTER applying this Pull Request

The user can swith off the logo

Documentation Changes Required

yes

[brianteeman]

It is confusing having a module and an options with the same name that control different things.
The way it is used here in the options it is not clear what it does unless you read the code
Is it intentional that you can have two brands?

I think you need to rethink the approach here.

[chmst]

Have you a suggestion for a name of the module position? Maybe below-top?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33751.}

[brianteeman]

Thinking out aloud.

How about instead of saying Brand Yes|No maybe Template|Module would make more sense?

[chmst]

I agree that the name brand for a moduleposition is wrong, as the position canbe used for everything. It is independent from
displaying the brand ( = Logo / Description and Tagline ).

[ghost]

I have tested this item ✅ successfully on dba8af8

Similar position in github named "Header".

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33751.}

[chmst]

I have changed the name, thanks for the hint.

The position below-top can be be used independent form the brand ( logo / description + tagliene).

[ghost]

I have tested this item ✅ successfully on 7894923

1. Setting in template style:

2. Frontend:

3. Frontend + Language switcher in position "below-top":

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33751.}

[ChristineWk]

I have tested this item ✅ successfully on 7894923

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33751.}

[richard67]

@chmst Please add the missing language string for the new module position to file language/en-GB/tpl_cassiopeia.sys.ini so that people see a nice module position name in the pulldown, like we have it e.g. for the "Menu" position, where we see "Menu" and not "menu".

The name of the language string has to be: TPL_CASSIOPEIA_POSITION_BELOW-TOP.

[chmst]

Language string added, Thanks @richard67

[richard67]

Language string added, Thanks @richard67

As far as I know, the name of the language string after the last underscore has to be equal to the name in the XML converted to uppercase.

That means it should be TPL_CASSIOPEIA_POSITION_BELOW-TOP.

But you have added TPL_CASSIOPEIA_POSITION_BELOW_TOP.

Just below you can see for bottom-a and bottom-b how it shoud be.

[richard67]

@sandramay0905 @ChristineWk Could you briefly test this PR again? It has received a change so that when you select the new module position for a module, you see the nice, translatable language string "Below Top" in the dropdown, instead of the raw "below-top" from the XML file. Just test this new change, the rest hasn't changed. Thanks in advance, and thanks so far for all previous testing here and elsewhere.

[ChristineWk]

Should be OK:

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33751.}

[ChristineWk]

I have tested this item ✅ successfully on 231cc0f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33751.}

[richard67]

@ChristineWk What I meant with the changed thing to be tested was the name of the module position in backend, when you select the position:

Before the last change, it was just "below-top", or maybe "below-top [below-top]", now it has the "Below Top" at the beginning, which is a translatable text.

[ChristineWk]

Ah, OK :-)

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33751.}

[brianteeman]

I have tested this item ✅ successfully on 231cc0f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33751.}

[brianteeman]

I have tested this item 🔴 unsuccessfully on 231cc0f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33751.}

[brianteeman]

I have tested this item ✅ successfully on 231cc0f

sorry this is a good test

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33751.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33751.}

[brianteeman]

Shouldnt the param have been set in the database on install? (it hasnt been and therefore the problem)

[richard67]

@brianteeman @PhilETaylor I'll make a PR soon.

[richard67]

@brianteeman @PhilETaylor PR #33881 is ready, please test. Thanks in advance.

[infograf768]

While I was working on #31275 I discovered that I had issues when using the lang switcher with flags as a dropdown in the new position.

I will have to add the color in the module css

div.mod-languages .btn-group .btn {
    flex: none;
    color: #000;
}

[richard67]

@brianteeman @PhilETaylor I've meanwhile replace my PR by a new, better one, for the issue with the header section not shown after a new installation or an update before having saved template style parameters. Please test #33930 . Thanks in advance.