[4.0] Dialoges Should be labeled

[Krshivam25]

For any container whose contents act as a dialog box (for example, a modal dialog asking the user to make a choice or respond to an action being taken), give it a descriptive label or name, so that assistive technology users can easily discover what its purpose is.

Testing Instructions :

Arrow Indicating Dialog box .

Improvement: Dialog was not accessible before. Whenever we are adding a dialog role we must provide an accessible name for a dialog, which can be done with the aria-label or aria-labelledby attribute.

[ghost]

@Krshivam25 can you please provide test instructions?

[jwaisner]

@Krshivam25 , can you please provide testing instructions for your PR?

[RickR2H]

I have tested this item ✅ successfully on a3f8154

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34383.}

[RickR2H]

@jwaisner and @sandramay0905 Just look if the aria-label is added to the dialog after applying the patch.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34383.}

[brianteeman]

Instead of duplicating the text it is better to add an id to the heading and use aria-labelledby

[hans2103]

@Krshivam25

you write:

<joomla-alert type="info" dismiss="true" class="js-pstats-alert hidden" role="alertdialog" aria-label="<?php echo Text::_('PLG_SYSTEM_STATS_LABEL_MESSAGE_TITLE'); ?>">
	<div class="alert-heading"><?php echo Text::_('PLG_SYSTEM_STATS_LABEL_MESSAGE_TITLE'); ?></div>

and just like @brianteeman writes, you can prevent double text by another implementation...using aria-labelledby

<joomla-alert type="info" dismiss="true" class="js-pstats-alert hidden" role="alertdialog" aria-labelledby="alert-stats-heading">
	<div id="alert-stats-heading" class="alert-heading"><?php echo Text::_('PLG_SYSTEM_STATS_LABEL_MESSAGE_TITLE'); ?></div>

[hans2103]

you have added:

<div id="alert-stats-heading" class="alert-heading"><?php echo Text::_('PLG_SYSTEM_STATS_LABEL_MESSAGE_TITLE'); ?></div>

please remove

<div class="alert-heading"><?php echo Text::_('PLG_SYSTEM_STATS_LABEL_MESSAGE_TITLE'); ?></div>

there is a duplicate alert-heading now

[Quy]

I have tested this item ✅ successfully on bbde261

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34383.}

[hans2103]

I have tested this item ✅ successfully on bbde261

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34383.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34383.}

[Krshivam25]

Thank you

[chmst]

Thanks!