Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Cassiopeia - Remove 'debug' from grid area and add min-height to 'body' #34849

Merged
merged 1 commit into from Jul 21, 2021

Conversation

drmenzelit
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Removed the grid area debug
Added min-height to body

Testing Instructions

Create a page with short content.
Test with debug enabled.

Actual result BEFORE applying this Pull Request

If the css grid contains an area for debug the template adds a gap under the footer.
In short pages the footer shows middle on the page instead of at the bottom, because the body has no height defined:
Screenshot 2021-07-20 at 12-05-25 Love
Screenshot 2021-07-20 at 12-06-07 Love
Screenshot 2021-07-20 at 12-06-25 Love

Expected result AFTER applying this Pull Request

No gap under the footer, footer at the bottom of the page no matter the length of the content, debug is displayed correctly without specifically defined grid area
Screenshot 2021-07-20 at 12-04-28 Love
Screenshot 2021-07-20 at 12-03-46 Love
Screenshot 2021-07-20 at 12-04-06 Love

Documentation Changes Required

@drmenzelit drmenzelit added this to the Joomla 4.0 milestone Jul 20, 2021
@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Jul 20, 2021
@chmst
Copy link
Contributor

chmst commented Jul 20, 2021

I have tested this item ✅ successfully on 16ecf62

Thanks! It is just what I need for my new project.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34849.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 16ecf62

Finally I got it. Thanks for assistance @chmst
(Tried on another page with the same article as above 'love')


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34849.

@Quy Quy removed Frontend Template NPM Resource Changed This Pull Request can't be tested by Patchtester labels Jul 20, 2021
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Jul 20, 2021
@Quy
Copy link
Contributor

Quy commented Jul 20, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34849.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 20, 2021
@Quy Quy added this to the Joomla 4.0 milestone Jul 20, 2021
@bembelimen bembelimen merged commit 97eab03 into joomla:4.0-dev Jul 21, 2021
@bembelimen
Copy link
Contributor

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants