Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] Correctly re-translate the date/time string in the calendar based on language file #35207

Closed
wants to merge 2 commits into from
Closed

Conversation

PhilETaylor
Copy link
Contributor

Pull Request for Issue #35204

Summary of Changes

Correctly re-translate the date/time string in the calendar based on language file

Also set the CORRECT en-GB value for the date/time string in PHP syntax DATE_FORMAT_CALENDAR_DATETIME as "%Y-%m-%d %H:%i:%s" - note this has been copied and pasted to other language packs and EVERY ONE will be broken... (Checked US and AU )

Testing Instructions

Install Joomla 4 with US language set as default
Try to create an article manually specifying a start publishing date and try to save

Actual result BEFORE applying this Pull Request

Screenshot 2021-08-17 at 22 52 52

Expected result AFTER applying this Pull Request

Article Saves

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Aug 17, 2021
@PhilETaylor

This comment was marked as abuse.

@HLeithner
Copy link
Member

%H:%M:%S is the wrong time... in all the packs I looked at (GB US AU)

- DATE_FORMAT_CALENDAR_DATETIME="%Y-%m-%d %H:%M:%S"
+ DATE_FORMAT_CALENDAR_DATETIME="%Y-%m-%d %H:%i:%s"

does the new calendar uses a different format? The value is 5 years old? #12102

@HLeithner
Copy link
Member

Maybe this string is used later in php which it shouldn't?

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor PhilETaylor deleted the calendaruseformat branch August 17, 2021 22:43
@PhilETaylor

This comment was marked as abuse.

@particthistle
Copy link
Member

  • en-GB error may have been in core string.
  • en-AU and en-US were then a copy at that specific point in time.
  • At the time I translated them, the date string did not have the code highlighting on it to indicate to translators "Don't change this one"

@PhilETaylor

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants