Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] Add padding in breadcrumbs when "You are here" not shown. #35253

Merged
merged 2 commits into from Aug 22, 2021
Merged

[4] Add padding in breadcrumbs when "You are here" not shown. #35253

merged 2 commits into from Aug 22, 2021

Conversation

PhilETaylor
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Add padding in breadcrumbs when "You are here" not shown and an image is shown instead

Testing Instructions

Edit breadcrumbs module - set "You are here" to OFF.

Actual result BEFORE applying this Pull Request

Screenshot 2021-08-20 at 16 04 26

Expected result AFTER applying this Pull Request

Screenshot 2021-08-20 at 16 04 32

Documentation Changes Required

@brianteeman
Copy link
Contributor

A valid issue but should be fixed with css not by hard coding a space. Especially as the css already exists, and is used elsewhere, for this. Just add the correct class

.fa-fw, .icon-fw {
    text-align: center;
    width: 1.25em;
}

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 5641d26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35253.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Aug 20, 2021

I have tested this item ✅ successfully on 5641d26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35253.

@Quy
Copy link
Contributor

Quy commented Aug 20, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35253.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 20, 2021
@bembelimen bembelimen merged commit 173ac7d into joomla:4.0-dev Aug 22, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 22, 2021
@bembelimen
Copy link
Contributor

Thanks

@bembelimen bembelimen added this to the Joomla 4.0.1 milestone Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants