Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] use correct object to get message from #37213

Merged
merged 3 commits into from Mar 6, 2022
Merged

[4] use correct object to get message from #37213

merged 3 commits into from Mar 6, 2022

Conversation

PhilETaylor
Copy link
Contributor

@PhilETaylor PhilETaylor commented Mar 6, 2022

Summary of Changes

There is no such method as $db->getMessage() - one assumes you are trying to get the exception message?

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

The code would fatal error if this exception block was ever invoked

Expected result AFTER applying this Pull Request

The exception would be correctly reported

Documentation Changes Required

none

@sandewt
Copy link
Contributor

sandewt commented Mar 6, 2022

I have tested this item ✅ successfully on c9998f3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37213.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Mar 6, 2022

I have tested this item ✅ successfully on c9998f3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37213.

@Quy
Copy link
Contributor

Quy commented Mar 6, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37213.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 6, 2022
@richard67 richard67 added this to the Joomla 4.1.1 milestone Mar 6, 2022
@richard67 richard67 merged commit ded0867 into joomla:4.1-dev Mar 6, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 6, 2022
@richard67
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants