Make all Cassiopeia variables !default#37360
Merged
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on ab8a55e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37360. |
Quy
reviewed
Mar 24, 2022
Contributor
|
I have tested this item ✅ successfully on 59da1f7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37360. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 59da1f7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37360. |
Member
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37360. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
In this PR I I added the "!default" setting to all the Cassiopeia variables. There where some variables who had already this setting in place, but now all variables are set as default. Setting the"!default" makes is easier for developers to create custom styling based on the Cassiopeia template for child themes for instance.
Use case:
After a child theme is created, create in the media/templates/site/CHILD_THEME a /scss folder
in this folder create a template.scss with the following content:
Next copy the template-rtl.scss from the media/templates/site/cassiopeia/scss folder to the child theme /scss folder.
Compile the template.scss and template-rtl.scss to the /css folder of the child theme
After compiling the CSS is build and the variable overrides are respected.
Set the child theme under the template settings in the backend and see the result.
Testing Instructions
Checkout this PR and compile the styling with npm ci.
Everything should work a normal.