Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all Cassiopeia variables !default #37360

Merged
merged 3 commits into from
Apr 2, 2022
Merged

Make all Cassiopeia variables !default #37360

merged 3 commits into from
Apr 2, 2022

Conversation

RickR2H
Copy link
Member

@RickR2H RickR2H commented Mar 24, 2022

Pull Request for Issue # .

Summary of Changes

In this PR I I added the "!default" setting to all the Cassiopeia variables. There where some variables who had already this setting in place, but now all variables are set as default. Setting the"!default" makes is easier for developers to create custom styling based on the Cassiopeia template for child themes for instance.

Use case:
After a child theme is created, create in the media/templates/site/CHILD_THEME a /scss folder
in this folder create a template.scss with the following content:

$secondary: red;
$success: red;
$info: red;
$warning: red;
$danger: red;

@import "../../cassiopeia/scss/template.scss";
// Your extra custom styling below

Next copy the template-rtl.scss from the media/templates/site/cassiopeia/scss folder to the child theme /scss folder.
Compile the template.scss and template-rtl.scss to the /css folder of the child theme
After compiling the CSS is build and the variable overrides are respected.
Set the child theme under the template settings in the backend and see the result.

Testing Instructions

Checkout this PR and compile the styling with npm ci.
Everything should work a normal.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.1-dev labels Mar 24, 2022
@ricardo1709
Copy link
Contributor

I have tested this item ✅ successfully on ab8a55e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37360.

@MSnoeren
Copy link
Contributor

I have tested this item ✅ successfully on 59da1f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37360.

1 similar comment
@ricardo1709
Copy link
Contributor

I have tested this item ✅ successfully on 59da1f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37360.

@RickR2H
Copy link
Member Author

RickR2H commented Mar 25, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37360.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 25, 2022
@Quy Quy added this to the Joomla 4.1.3 milestone Apr 2, 2022
@laoneo laoneo merged commit 46ca5db into joomla:4.1-dev Apr 2, 2022
@laoneo
Copy link
Member

laoneo commented Apr 2, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants