Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVG upload #37703

Merged
merged 2 commits into from
May 1, 2022
Merged

Fix SVG upload #37703

merged 2 commits into from
May 1, 2022

Conversation

bembelimen
Copy link
Contributor

Pull Request for Issue #37439 .

Summary of Changes

  • Invalid SVG files with broken structure
  • Allows comments in SVG files

Testing Instructions

Allow svg in the media manager options (mime: image/svg+xml, extension: svg).
Take the file package from @brianteeman #37439 (comment) and try uploading the files.

Actual result BEFORE applying this Pull Request

bad1.svg + bad3.svg is uploaded (both should be blocked), bad2.svg (false positive) + bad4.svg is rejected

Expected result AFTER applying this Pull Request

only "bad2.svg" is uploaded all other files are rejected

@woluweb could you test please?

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 7d05411


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37703.

@toivo
Copy link
Contributor

toivo commented May 1, 2022

I have tested this item ✅ successfully on 7d05411

Tested successfully in Joomla 4.1.3-dev of 30 April in Wampserver 3.2.8 using PHP 8.0.15


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37703.

@chmst
Copy link
Contributor

chmst commented May 1, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37703.

@chmst chmst removed the PR-4.1-dev label May 1, 2022
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 1, 2022
@akshitrattan
Copy link

I have tested this item ✅ successfully on 0816b10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37703.

@bembelimen bembelimen merged commit 699d424 into joomla:4.1-dev May 1, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 1, 2022
@bembelimen
Copy link
Contributor Author

Thx for testing

@bembelimen bembelimen added this to the Joomla 4.1.3 milestone May 1, 2022
@bembelimen bembelimen deleted the 4.1/37439 branch March 15, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants