Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment on the engine portion about upgrades #37830

Merged
merged 4 commits into from Jun 5, 2022

Conversation

dgrammatiko
Copy link
Contributor

So that the internal tools won't be broken

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

This is purely a comment so any future upgrades of node/npm won't break the rest of the internal tools

So that the internal tools won't be broken
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.1-dev labels May 19, 2022
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 7927b8d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37830.

1 similar comment
@jwaisner
Copy link
Member

jwaisner commented Jun 1, 2022

I have tested this item ✅ successfully on 7927b8d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37830.

@jwaisner
Copy link
Member

jwaisner commented Jun 1, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37830.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 1, 2022
@bembelimen bembelimen merged commit c1bc10d into joomla:4.1-dev Jun 5, 2022
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 5, 2022
@bembelimen bembelimen added this to the Joomla 4.1.5 milestone Jun 5, 2022
@dgrammatiko dgrammatiko deleted the patch-2 branch June 5, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants