Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] npm update #38105

Closed
wants to merge 3 commits into from
Closed

Conversation

brianteeman
Copy link
Contributor

Summary of Changes

CodeMirror updated to 5.65.6
and various dev dependencies

All scripts that are not dev dependencies have already been updated or are semver compatible

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Jun 20, 2022
@brianteeman
Copy link
Contributor Author

testing should be quite simple. Apply the pr. then npm ci

There should be no new files to commit

then run npm outdated and the output will be
image

@brianteeman brianteeman reopened this Jun 20, 2022
@laoneo
Copy link
Member

laoneo commented Jun 20, 2022

Vue should be updated as well as it is only a patch shift.

@brianteeman
Copy link
Contributor Author

@laoneo thanks - vue was locked to a specific patch release. Its not any more

@laoneo
Copy link
Member

laoneo commented Jun 20, 2022

Then I'm wondering why it got locked. It was done in #36295. @dgrammatiko any reason you locked vue to a specific release?

@dgrammatiko
Copy link
Contributor

@dgrammatiko any reason you locked vue to a specific release?

Yes, the reason is security and assuring that the person in charge of releases will NOT accidentally distribute a version that was not tested/peer reviewed/etc. FWIW for years I kept asking for an automated solution for both npm+composer but gloriously ignored. Anyways, both package.json and composer.json SHOULD point to specific versions for the dependencies (joomla is not a weekend project, so maintainers should treat it respectively).

An implementation of renovate bot in this repo will apply this before start doing any PRs for updating any of the dependencies (you can check it in one of my many repos where I use it for quite some time, eg: package.josn renovate.josn ).

@laoneo
Copy link
Member

laoneo commented Jun 21, 2022

The lock file does the job of pointing to a specific version. There is no need to do that in the config file as well, except when there is a bug/incompatibility/whatever in the library and we have to stick to a specific version.

@dgrammatiko
Copy link
Contributor

@laoneo sure but everybody is using specific version on their package.json, eg: https://github.com/WordPress/wordpress-develop/blob/40c4f11a81ee28b1ec1869c9842064ac0bf137c2/package.json#L78-L156

@brianteeman
Copy link
Contributor Author

if everybody was doing that then there would be zero point in the ^ or ~ functionality existing.

@brianteeman
Copy link
Contributor Author

closed. i'm not wasting my time resolving conflicts

@brianteeman brianteeman deleted the 4.2-npm_update branch June 23, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants