Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Empty error message in package install #38227

Merged
merged 4 commits into from Jul 12, 2022

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #37575 .

Summary of Changes

Display an error message with text not just an empty error

Testing Instructions

npm run build:js
or install prebuilt package

Go to the package installer and try to drag & drop a folder

Actual result BEFORE applying this Pull Request

image

and js error in the console

Expected result AFTER applying this Pull Request

image

and no console errors

Documentation Changes Required

none

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Jul 5, 2022
@richard67
Copy link
Member

richard67 commented Jul 5, 2022

Unfortunately I cannot reproduce the issue here on a clean, current 4.2-dev without this PR. I don't get an empty error message when trying to upload a folder. I get a message "No Install Type Found". I've tried an empty folder and a folder with one empty file and also a folder with files and subfolders. In all cases the same result. What am I doing wrong?

P.S. The message I get is of type information or has no type. It has blue background.

@brianteeman
Copy link
Contributor Author

were you using drag and drop?

@richard67
Copy link
Member

were you using drag and drop?

Yes, was on administrator/index.php?option=com_installer&view=install and dragged the folder from my Windows 10 Desktop into the drop area of that page.

@richard67
Copy link
Member

After I've dropped the folder, it shows "Uploading 0%" or something like that for a while, and then:
2022-07-05_1

Client (browser) is Windows, and the webserver is Linux.

@richard67
Copy link
Member

What a pity because I think this PR is right now, and I wanted to test it with success, only I can't reproduce the issue.

@Fedik
Copy link
Member

Fedik commented Jul 5, 2022

Maybe some OS specific, I have "empty error" as in description, when doing "folder drag and drop" in Linux in Chrome

@brianteeman
Copy link
Contributor Author

recorded on windows 11

Before

before

@richard67
Copy link
Member

Hmm, no, same result when I use Firefox on my Linux server directly.

@richard67
Copy link
Member

@pearlpriyanka Did you have your issue #37575 with Windows 11 as client OS where the browser was used?

@richard67
Copy link
Member

Hmm, anyway, I believe you guys of course, no need for a video or animated gif. I just can't reproduce it here and would like to know why.

@Fedik
Copy link
Member

Fedik commented Jul 5, 2022

I have tested this item ✅ successfully on e57fc28


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38227.

1 similar comment
@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on e57fc28


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38227.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38227.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 5, 2022
@roland-d roland-d merged commit 1574e35 into joomla:4.2-dev Jul 12, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 12, 2022
@roland-d
Copy link
Contributor

Thank you. As for the discussion of which mime-types to check, that can be a separate issue.

Kostelano added a commit to JPathRu/localisation that referenced this pull request Jul 19, 2022
joomla/joomla-cms#36749 +
joomla/joomla-cms#38228 +
joomla/joomla-cms#38227 - (только для en-GB, у нас исправлено ранее)
joomla/joomla-cms#38255 +
joomla/joomla-cms#38244 +
joomla/joomla-cms#38271 - (только для en-GB, у нас исправлено ранее)
joomla/joomla-cms#38287 - (только для en-GB, у нас исправлено ранее)
joomla/joomla-cms#38301 - (только для en-GB, у нас исправлено ранее)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants