-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4][com_actionlog] - log event reset password #39435
Conversation
please fill out PR info properly. |
Surely, adding new events is not necessary to fix the reported issue? |
I have tested this item ✅ successfully on fa80696 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39435. |
I have tested this item ✅ successfully on fa80696 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39435. |
Hmm there is a comment with a valid concern: #39435 (comment) . We should not add new events when it‘s not needed. |
What's the scope of the Events then ? |
@alikon Have you checked if there is an existing event which can be used? If you say yes and there was none, I am ok with it. |
in the previous version 3 it was used |
I think it is fine to create new events for thinks like this, but it should be consisted overt the whole process |
I have tested this item ✅ successfully on ba1d350 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39435. |
I have tested this item ✅ successfully on ba1d350 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39435. |
@alikon If I understand @rdeutz 's comment right, he means that if we add events |
@richard67 yes and yes. |
@alikon Could you check the previous two comments and if possible implement the requested changes? It would be good to bring this useful PR forward. Let us know if you need some help or other that or further advice. Thanks in advance. |
added the |
I tested again. At the moment, the PR is broken, something needs to be fixed (problem after the last changes). A request to remind the login comes to the mail, a request to change the password does not. I tried several times. |
I have tested this item ✅ successfully on afc06a4 Why did it happen that at first it did not work: I created a user and, in addition to the "Registered" group, added him to the Superusers group. The system does NOT send a password change request for a group of Superusers (which is strange because I have seen error lines for superusers who want to change the password). In this case, the system proceeds to the next stage - entering a login / confirmation code, but nothing comes to the mail. Well, that's a bug for a separate fix. As soon as I removed the user from the superuser group, everything began to work. Everything is displayed correctly in the action log. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39435. |
I have tested this item ✅ successfully on afc06a4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39435. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39435. |
@alikon Did I miss something, because as far as I know brackets are preferred in J4? You probably have a reason for it. |
Thank you |
@sandewt i'll change it to |
Pull Request for Issue #39062.
Summary of Changes
generate proper event
Testing Instructions
Actual result BEFORE applying this Pull Request
see #39435
Expected result AFTER applying this Pull Request
the events are correctly logged in Action Logged
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed