Skip to content

[5.1] New Article site #39506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

brianteeman
Copy link
Contributor

If you are authorised to create content on the front end of the site then in a category list view you have an edit button for each article and a button to create a new article

If you are authorised to create content on the front end of the site then in a category blog view you have an edit button for each article and NO button to create a new article

This PR adds a new article button to a category blog view

To test
Apply PR
Log in to the front end of your site and go to any blog category page and you will now have a new article button at the bottom

image

If you are authorised to create content on the front end of the site then in a category list view you have an edit button for each article and a button to create a new article

If you are authorised to create content on the front end of the site then in a category blog view you have an edit button for each article and NO button to create a new article

This PR adds a new article button to a category blog view

To test
Apply PR
Log in to the front end of your site and go to any blog category page and you will now have a new article button at the bottom
@Kostelano
Copy link
Contributor

It works. But the button looks so out of place that I will leave my vote against. Without speaking in principle about the button at the very end of the page, when there can be quite a lot of articles on it like for a blog, there is also an option when the blog is the main page and this button also looks out of place. As for me - the ability to create articles is better controlled by any menu item in any menu in the right place. In principle, the same situation applies to the LIST layout, where we currently have a create button.

@brianteeman
Copy link
Contributor Author

Going to ignore those comments. This is no different to the list view

@Catriona
Copy link

See issue #39558, there is a problem with the New Article button on the list view in that it uses the wrong category.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39506.

@chmst chmst added the Small A PR which only has a small change label Feb 25, 2023
@Hackwar Hackwar added the Feature label Apr 7, 2023
@HLeithner HLeithner changed the base branch from 4.3-dev to 5.0-dev May 8, 2023 15:02
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.

@brianteeman brianteeman changed the title [4.3] New Article site [5.0] New Article site May 8, 2023
@brianteeman brianteeman closed this Sep 8, 2023
@brianteeman brianteeman deleted the new_article_frontend branch September 8, 2023 11:48
@brianteeman brianteeman restored the new_article_frontend branch September 24, 2023 07:56
@brianteeman brianteeman reopened this Sep 24, 2023
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:50
@brianteeman brianteeman changed the title [5.0] New Article site [5.1] New Article site Sep 30, 2023
@Hackwar Hackwar added the PBF Pizza, Bugs and Fun label Feb 21, 2024
@dorisdreher
Copy link

I have tested this item ✅ successfully on b2c6654


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39506.

@faustonenci
Copy link

I have tested this item ✅ successfully on b2c6654

good work


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39506.

@richard67 richard67 removed PBF Pizza, Bugs and Fun Small A PR which only has a small change PR-5.1-dev labels Feb 24, 2024
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39506.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 24, 2024
@richard67 richard67 added PBF Pizza, Bugs and Fun Small A PR which only has a small change PR-5.1-dev and removed PR-5.0-dev labels Feb 24, 2024
@walturbo
Copy link

Hi @brianteeman, I applied the patch but the "New Article" button does not appear in blog view.
I'm using a child of Cassiopeia.

If I go to Templates Customise: /templates/cassiopeia_rlm/html/com_content/category/blog.php I can see the change compared to the original file

diff

But it is not reported as "Override Files" change

diff 2

I confirm that by returning to the Cassiopeia parent template I can see the New Article button from the front end.

@brianteeman
Copy link
Contributor Author

That is expected behaviour

@devcodemonkey
Copy link

I have tested this item ✅ successfully on b2c6654


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39506.

2 similar comments
@pe7er
Copy link
Contributor

pe7er commented Feb 24, 2024

I have tested this item ✅ successfully on b2c6654


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39506.

@walturbo
Copy link

I have tested this item ✅ successfully on b2c6654


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39506.

@bembelimen bembelimen merged commit 34af997 into joomla:5.1-dev Feb 28, 2024
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 28, 2024
@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Feb 28, 2024
@brianteeman
Copy link
Contributor Author

Thanks all

@brianteeman brianteeman deleted the new_article_frontend branch February 28, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PBF Pizza, Bugs and Fun Small A PR which only has a small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.