Skip to content

Mail template fix "reply to"#39893

Merged
roland-d merged 3 commits into
joomla:4.2-devfrom
Fedik:fix-mailtmpl-reply
Feb 23, 2023
Merged

Mail template fix "reply to"#39893
roland-d merged 3 commits into
joomla:4.2-devfrom
Fedik:fix-mailtmpl-reply

Conversation

@Fedik
Copy link
Copy Markdown
Member

@Fedik Fedik commented Feb 20, 2023

Pull Request for Issue #37473 .

Summary of Changes

Mail template should use replyto from config, when available

Testing Instructions

Please follow #37473
Or add "Reply-To" in Global config, save (!!), and send test email.

Actual result BEFORE applying this Pull Request

Reply-To is missing

Expected result AFTER applying this Pull Request

Reply-To is there

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@toivo
Copy link
Copy Markdown
Contributor

toivo commented Feb 20, 2023

I have tested this item ✅ successfully on 0e2aa37

Tested successfully in Joomla 4.2.28-dev of 20 February in Wampserver 3.2.9 using PHP 8.1.10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39893.

Comment thread libraries/src/Mail/MailTemplate.php Outdated
Comment thread libraries/src/Mail/MailTemplate.php Outdated
@ChristineWk
Copy link
Copy Markdown

I have tested this item ✅ successfully on 0e2aa37


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39893.

@richard67
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39893.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 20, 2023
@joomdonation
Copy link
Copy Markdown
Contributor

@toivo or @ChristineWk Could one of you help re-testing this PR ? After that, it will be ready to be merged.

@ChristineWk
Copy link
Copy Markdown

I have tested this item ✅ successfully on 523b6a2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39893.

@ChristineWk
Copy link
Copy Markdown

Screenshot 2023-02-23 110913

@joomdonation
Copy link
Copy Markdown
Contributor

Thanks @ChristineWk. RTC because the last commit was just a simple rename variables and we now have one actual human tested it with successful test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39893.

@roland-d roland-d merged commit 0a25028 into joomla:4.2-dev Feb 23, 2023
@roland-d
Copy link
Copy Markdown
Contributor

Thank you

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 23, 2023
@roland-d roland-d added this to the Joomla! 4.2.9 milestone Feb 23, 2023
@Fedik Fedik deleted the fix-mailtmpl-reply branch February 23, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants