Mail template fix "reply to" #39893
Merged
Mail template fix "reply to" #39893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 0e2aa37 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39893. |
|
I have tested this item ✅ successfully on 0e2aa37 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39893. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39893. |
|
@toivo or @ChristineWk Could one of you help re-testing this PR ? After that, it will be ready to be merged. |
|
I have tested this item ✅ successfully on 523b6a2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39893. |
|
|
|
Thanks @ChristineWk. RTC because the last commit was just a simple rename variables and we now have one actual human tested it with successful test. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39893. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #37473 .
Summary of Changes
Mail template should use replyto from config, when available
Testing Instructions
Please follow #37473
Or add "Reply-To" in Global config, save (!!), and send test email.
Actual result BEFORE applying this Pull Request
Reply-To is missing
Expected result AFTER applying this Pull Request
Reply-To is there
Link to documentations
Please select: