Skip to content

Fixing URL to contact VCF #39938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2023
Merged

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Feb 25, 2023

Summary of Changes

The link for the VCF file for a contact is wrong.

Testing Instructions

Go to the contact component and enable showing the VCF link to a contact. Click on that link in the frontend.

Actual result BEFORE applying this Pull Request

You get a 404.

Expected result AFTER applying this Pull Request

You get the correct file.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Hackwar Hackwar added the Small A PR which only has a small change label Feb 25, 2023
@toivo
Copy link
Contributor

toivo commented Feb 26, 2023

I have tested this item 🔴 unsuccessfully on a18f861

The link to the vCard worked every time with or without this PR, as show below.
Using Joomla 4.2.9-dev of 26 February and PHP 8.1.10 in Wampserver.

SEF URLs and URL rewriting enabled
before PR: http://joomla4test/contact?format=vcf
after PR: http://joomla4test/contact?format=vcf

SEF URLs and URL rewriting not selected
before PR: http://joomla4test/index.php?option=com_contact&view=contact&id=1&format=vcf&Itemid=150
after PR: http://joomla4test/index.php?option=com_contact&view=contact&catid=9:webmasters&id=1:toivo&format=vcf&Itemid=150


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39938.

@Hackwar
Copy link
Member Author

Hackwar commented Feb 27, 2023

I'm sorry, I was a bit in a rush when I wrote all of this. The URL can be right by accident, however it fails when you have a menu item to a category of contacts and the contact is in a child category of that first category.

@toivo
Copy link
Contributor

toivo commented Mar 2, 2023

I have tested this item ✅ successfully on a18f861

@Hackwar, thank you for the detailed description.
Tested successfully in Joomla 4.2.9-dev of 2 March in PHP 8.1.10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39938.

@Quy
Copy link
Contributor

Quy commented Mar 2, 2023

I have tested this item ✅ successfully on a18f861


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39938.

@Quy Quy removed the Small A PR which only has a small change label Mar 2, 2023
@Quy
Copy link
Contributor

Quy commented Mar 2, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39938.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 2, 2023
@fancyFranci fancyFranci merged commit 8da0072 into joomla:4.2-dev Mar 4, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 4, 2023
@fancyFranci fancyFranci added this to the Joomla! 4.2.9 milestone Mar 4, 2023
@fancyFranci
Copy link
Contributor

Thank you!

@nielsnuebel
Copy link
Contributor

@Hackwar Thanks for fixing my Discover bug at JoomlaCamp 😉. I was also able to test successfully

@Hackwar Hackwar deleted the 4.2-contact-vcf branch April 17, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants