-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Fixing URL to contact VCF #39938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing URL to contact VCF #39938
Conversation
I have tested this item 🔴 unsuccessfully on a18f861 SEF URLs and URL rewriting enabled SEF URLs and URL rewriting not selected This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39938. |
I'm sorry, I was a bit in a rush when I wrote all of this. The URL can be right by accident, however it fails when you have a menu item to a category of contacts and the contact is in a child category of that first category. |
I have tested this item ✅ successfully on a18f861 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39938. |
I have tested this item ✅ successfully on a18f861 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39938. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39938. |
Thank you! |
@Hackwar Thanks for fixing my Discover bug at JoomlaCamp 😉. I was also able to test successfully |
Summary of Changes
The link for the VCF file for a contact is wrong.
Testing Instructions
Go to the contact component and enable showing the VCF link to a contact. Click on that link in the frontend.
Actual result BEFORE applying this Pull Request
You get a 404.
Expected result AFTER applying this Pull Request
You get the correct file.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed