Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Joomla Dialog for Aricles, Categories batch and Finder Index with Statistic #40359

Merged
merged 17 commits into from Sep 5, 2023

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Apr 10, 2023

Summary of Changes

An implementation of Joomla Dialog for for Aricles, Categories batch and Finder Index with Statistic.
Depends from #40150

It works but not fully finished.
It still will be need some stilyng for batch modals and solution for 'onclose' 🥔

->onclose('window.parent.location.reload()')

Testing Instructions

Apply patch then apply #40150, run npm install.
Check Article, Categories batch, and Finder Index wtih Statistic popups. Versions popup

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: [5.0] Toolbar popup button Manual#184
  • No documentation changes for manual.joomla.org needed

@Fedik Fedik marked this pull request as draft April 10, 2023 14:06
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Apr 10, 2023
@dgrammatiko
Copy link
Contributor

and solution for onclose

That needs to be killed, it's not CSP strict and by default it's an XSS vulnerability as users could execute any arbitrary code using that event. In sort all the inline events should be considered harmful and removed ASAP...

@Fedik
Copy link
Member Author

Fedik commented Apr 10, 2023

That needs to be killed, it's not CSP strict ...

I am fine with removing.
I have fixed it for Finder, however it still may be an issue for extensions.

@dgrammatiko
Copy link
Contributor

however it still may be an issue for extensions.

If Joomla is serious about security, those vectors should be removed. My 2c

@Fedik Fedik added the Feature label Apr 11, 2023
@Fedik Fedik changed the title Joomla Dialog for Aricles batch and Finder Index with Statistic Joomla Dialog for Aricles, Categories batch and Finder Index with Statistic Apr 12, 2023
@Fedik Fedik changed the title Joomla Dialog for Aricles, Categories batch and Finder Index with Statistic [5.0] Joomla Dialog for Aricles, Categories batch and Finder Index with Statistic Apr 23, 2023
 Conflicts:
	administrator/components/com_finder/src/View/Index/HtmlView.php
 Conflicts:
	build/media_source/com_content/joomla.asset.json
@Fedik Fedik marked this pull request as ready for review August 21, 2023 13:19
@HLeithner
Copy link
Member

i think the b/c plugin still has a reference to this es5?

@Fedik
Copy link
Member Author

Fedik commented Aug 22, 2023

hmhm, what to reference?

@HLeithner
Copy link
Member

hmm I think I comment on the wrong PR

@HLeithner HLeithner merged commit b0064dc into joomla:5.0-dev Sep 5, 2023
3 checks passed
@HLeithner
Copy link
Member

thanks, documentation update please

@HLeithner HLeithner added this to the Joomla! 5.0 milestone Sep 5, 2023
@Fedik Fedik deleted the popup-batch branch September 5, 2023 07:37
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 5, 2023
HLeithner pushed a commit that referenced this pull request Sep 5, 2023
…1598)

* Add deleted files from PR #40359

* Remove duplicate entry
@Fedik
Copy link
Member Author

Fedik commented Sep 5, 2023

There it is joomla/Manual#184

@Fedik Fedik mentioned this pull request Sep 20, 2023
4 tasks
@Fedik Fedik mentioned this pull request Nov 9, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Required Feature NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants