-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade font awesome to version 6 #40524
Conversation
I think that's not a sufficient test. It would also need to check if running "npm ci" (or "npm run build:js" and "npm run build:css") show any new errors or warnings. |
@laoneo this won’t cut it, as you break everything from j4 that are referencing fa5. Get the code from here: https://github.com/joomla/joomla-cms/pull/36906/files |
Can you not open then a new pr with the upgrade? I don't want to copy your code and you understand it more deeply than me. |
@dgrammatiko can you have a look again as I did copy the fontawesome related changes from #36906? |
LGTM |
can you create a documentation entry on manual joomla for this because it's a b/c break for some images (iirc some images are missing in 6) |
Just some heads up here, I was playing with FA6 for my template Muta and I think that in order to keep the b/c here the font-family needs to stay as |
Summary of Changes
Upgrades font awesome to version 6.
Testing Instructions
Browse around in Joomla.
Actual result BEFORE applying this Pull Request
All icons are displayed.
Expected result AFTER applying this Pull Request
All icons are displayed.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed