Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Console error due to missing dependency #42058

Merged
merged 3 commits into from Oct 5, 2023

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Oct 5, 2023

Pull Request for Issue #42056 .

Summary of Changes

Add the missing dependency in the view

Testing Instructions

Follow the issue #42056

Actual result BEFORE applying this Pull Request

Console error, side commands don't do anything

Expected result AFTER applying this Pull Request

Side commands work as expected

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

Signed-off-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
@Quy
Copy link
Contributor

Quy commented Oct 5, 2023

I have tested this item ✅ successfully on 0dfdeae

Thank you!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42058.

@Fedik
Copy link
Member

Fedik commented Oct 5, 2023

Please add the dependency to media/com_mails/joomla.asset.json instead, it will be more safe

@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Oct 5, 2023
@Fedik
Copy link
Member

Fedik commented Oct 5, 2023

I have tested this item ✅ successfully on c7d9d07


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42058.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Oct 5, 2023

I have tested this item ✅ successfully on c7d9d07


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42058.

@Quy Quy removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label Oct 5, 2023
@Quy
Copy link
Contributor

Quy commented Oct 5, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42058.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit NPM Resource Changed This Pull Request can't be tested by Patchtester labels Oct 5, 2023
Signed-off-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
@joomla-cms-bot joomla-cms-bot removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label Oct 5, 2023
@dgrammatiko
Copy link
Contributor Author

Sorry @Fedik @Quy I just figure out that the problem was the type of the field, not a forgotten dependency. So Fedir was right that some dependency was missing but that was because the field was wrongly set as textarea instead of editor. Can you please retest?

@Quy
Copy link
Contributor

Quy commented Oct 5, 2023

I have tested this item ✅ successfully on d347c86


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42058.

@HLeithner HLeithner merged commit 26ee726 into joomla:5.0-dev Oct 5, 2023
1 of 3 checks passed
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 5, 2023
@dgrammatiko dgrammatiko deleted the 5.0-dev-xe branch October 5, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants