[imp] Add the ability to use a custom.css with Protostar. #4211

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
@roland-d
Contributor

roland-d commented Sep 3, 2014

Currently it is impossible to use a custom.css file when using the Protostar template. A search on the net always ends up with a core hack of the index.php file, which could result in a problem when the index.php is being updated in a Joomla update.

This change checks if the file custom.css exists and if so, load it.

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Sep 3, 2014

Contributor

A similar PR is open for the backend here: #3709

Personally I don't like using a custom.css and would rather use a plugin/module to do the same. There are many already existing which do exactly that and more.

Contributor

Bakual commented Sep 3, 2014

A similar PR is open for the backend here: #3709

Personally I don't like using a custom.css and would rather use a plugin/module to do the same. There are many already existing which do exactly that and more.

@roland-d

This comment has been minimized.

Show comment
Hide comment
@roland-d

roland-d Sep 3, 2014

Contributor

Thanks @Bakual I did search but didn't find anything. Closing this in favor of #3709.

Contributor

roland-d commented Sep 3, 2014

Thanks @Bakual I did search but didn't find anything. Closing this in favor of #3709.

@roland-d roland-d closed this Sep 3, 2014

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Sep 3, 2014

Contributor

I am a fan of this approach

On 3 September 2014 11:20, Thomas Hunziker notifications@github.com wrote:

A similar PR is open for the backend here: #3709
#3709

Personally I don't like using a custom.css and would rather use a
plugin/module to do the same. There are many already existing which do
exactly that and more.


Reply to this email directly or view it on GitHub
#4211 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Contributor

brianteeman commented Sep 3, 2014

I am a fan of this approach

On 3 September 2014 11:20, Thomas Hunziker notifications@github.com wrote:

A similar PR is open for the backend here: #3709
#3709

Personally I don't like using a custom.css and would rather use a
plugin/module to do the same. There are many already existing which do
exactly that and more.


Reply to this email directly or view it on GitHub
#4211 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Sep 3, 2014

Contributor

Reopening because the other PR is backend and this one is frontend. 😄

Contributor

Bakual commented Sep 3, 2014

Reopening because the other PR is backend and this one is frontend. 😄

@Bakual Bakual reopened this Sep 3, 2014

@phproberto

This comment has been minimized.

Show comment
Hide comment
@phproberto

phproberto Sep 3, 2014

Contributor

I think we should do the file_exists check with the full path:

JPATH_SITE . "/templates/protostar/css/custom.css"

Contributor

phproberto commented Sep 3, 2014

I think we should do the file_exists check with the full path:

JPATH_SITE . "/templates/protostar/css/custom.css"

@roland-d

This comment has been minimized.

Show comment
Hide comment
@roland-d

roland-d Sep 3, 2014

Contributor

In that case all references to $this->template should be removed. How about that?

Contributor

roland-d commented Sep 3, 2014

In that case all references to $this->template should be removed. How about that?

@phproberto

This comment has been minimized.

Show comment
Hide comment
@phproberto

phproberto Sep 3, 2014

Contributor

Sorry I sent it from my smartphone. I mean:

file_exists(JPATH_SITE . '/templates/' . $this->template . '/css/custom.css')

Otherwise I think we can have problems with sites outside the root www.

Contributor

phproberto commented Sep 3, 2014

Sorry I sent it from my smartphone. I mean:

file_exists(JPATH_SITE . '/templates/' . $this->template . '/css/custom.css')

Otherwise I think we can have problems with sites outside the root www.

@roland-d

This comment has been minimized.

Show comment
Hide comment
@roland-d

roland-d Sep 3, 2014

Contributor

I agree @phproberto Change has been comitted.

Contributor

roland-d commented Sep 3, 2014

I agree @phproberto Change has been comitted.

@phproberto

This comment has been minimized.

Show comment
Hide comment
@phproberto

phproberto Sep 3, 2014

Contributor

Tested. Seems to work ok before and after the last commit 💃

Good job Roland!

Contributor

phproberto commented Sep 3, 2014

Tested. Seems to work ok before and after the last commit 💃

Good job Roland!

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Sep 10, 2014

Member

Not sure this would be B/C as some may have created a specific custom.css for TinyMCE only.

Member

infograf768 commented Sep 10, 2014

Not sure this would be B/C as some may have created a specific custom.css for TinyMCE only.

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Sep 10, 2014

Contributor

Not sure this would be B/C as some may have created a specific custom.css for TinyMCE only.

If I understand it correctly, the worst thing that could happen is that the custom.css file is loaded always, while it currently would be loaded only when an editor is loaded (like in a form).
I don't think that could break a template.

Also it would only be the case if someone uses the Protostar template.

Contributor

Bakual commented Sep 10, 2014

Not sure this would be B/C as some may have created a specific custom.css for TinyMCE only.

If I understand it correctly, the worst thing that could happen is that the custom.css file is loaded always, while it currently would be loaded only when an editor is loaded (like in a form).
I don't think that could break a template.

Also it would only be the case if someone uses the Protostar template.

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Sep 10, 2014

Member

It could break the template easily as someone may need specific css just for Tiny, and this custom.css would override the template.css

Member

infograf768 commented Sep 10, 2014

It could break the template easily as someone may need specific css just for Tiny, and this custom.css would override the template.css

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Sep 10, 2014

Member

Example:
The template wants some clear text on dark background (plain or with image). The template.css has been changed to obtain this. But editing in Tiny is easier when text is black over clear background or no background at all...

Member

infograf768 commented Sep 10, 2014

Example:
The template wants some clear text on dark background (plain or with image). The template.css has been changed to obtain this. But editing in Tiny is easier when text is black over clear background or no background at all...

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Sep 10, 2014

Contributor

But wouldn't that then break the template already currently when in a form with an editor? Or do you think they just don't care in that case but would if it spreads to the whole site?

Is that a generic TinyMCE feature that it loads the custom.css file if present?

Contributor

Bakual commented Sep 10, 2014

But wouldn't that then break the template already currently when in a form with an editor? Or do you think they just don't care in that case but would if it spreads to the whole site?

Is that a generic TinyMCE feature that it loads the custom.css file if present?

@roland-d

This comment has been minimized.

Show comment
Hide comment
@roland-d

roland-d Sep 11, 2014

Contributor

You can't use Tiny specific tags in the custom.css?

Contributor

roland-d commented Sep 11, 2014

You can't use Tiny specific tags in the custom.css?

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Sep 11, 2014

Member

PLG_TINY_FIELD_CUSTOM_CSS_DESC="Optional CSS file that will override the standard editor.css file. Enter a file name to point to a file in the CSS folder of the default template (for example, templates/beez3/css/). Or enter a full URL path to the custom CSS file. If you enter a value in this field, this file will be used instead of the editor.css file."

It is common to call that file custom.css is what I mean.
The classes in such a file are usually the same as in template.css, but with differences in rendering:
as said above, can be the colours or else:
for example

<p><span class="badge">test</span></p>

default css

.badge {
    display: inline-block;
    padding: 2px 4px;
    font-size: 10.998px;
    font-weight: bold;
    line-height: 14px;
    color: #fff;
    vertical-align: baseline;
    white-space: nowrap;
    text-shadow: 0 -1px 0 rgba(0,0,0,0.25);
    background-color: #999;
}

if the template css has been changed to display "badge" black text on white background, the badge effect will not show in TinyMCE edit field. The custom.css will include a modified version (in that case the original css would fit)
I let you imagine sites where this has been done for dozains of css and site gets totally messed up because the custom.css is loaded in frontend

Member

infograf768 commented Sep 11, 2014

PLG_TINY_FIELD_CUSTOM_CSS_DESC="Optional CSS file that will override the standard editor.css file. Enter a file name to point to a file in the CSS folder of the default template (for example, templates/beez3/css/). Or enter a full URL path to the custom CSS file. If you enter a value in this field, this file will be used instead of the editor.css file."

It is common to call that file custom.css is what I mean.
The classes in such a file are usually the same as in template.css, but with differences in rendering:
as said above, can be the colours or else:
for example

<p><span class="badge">test</span></p>

default css

.badge {
    display: inline-block;
    padding: 2px 4px;
    font-size: 10.998px;
    font-weight: bold;
    line-height: 14px;
    color: #fff;
    vertical-align: baseline;
    white-space: nowrap;
    text-shadow: 0 -1px 0 rgba(0,0,0,0.25);
    background-color: #999;
}

if the template css has been changed to display "badge" black text on white background, the badge effect will not show in TinyMCE edit field. The custom.css will include a modified version (in that case the original css would fit)
I let you imagine sites where this has been done for dozains of css and site gets totally messed up because the custom.css is loaded in frontend

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Sep 11, 2014

Contributor

Thanks for the explanation. I now understand what you mean.

Contributor

Bakual commented Sep 11, 2014

Thanks for the explanation. I now understand what you mean.

@roland-d

This comment has been minimized.

Show comment
Hide comment
@roland-d

roland-d Sep 27, 2014

Contributor

Closing this as there seems to be no way around it nor any interest.

Contributor

roland-d commented Sep 27, 2014

Closing this as there seems to be no way around it nor any interest.

@roland-d roland-d closed this Sep 27, 2014

@roland-d

This comment has been minimized.

Show comment
Hide comment
@roland-d

roland-d Jan 20, 2015

Contributor

This topic came up again at the local user group. So I am thinking is, if custom.css can't be used, what if we change the name to something else for example user.css?

Contributor

roland-d commented Jan 20, 2015

This topic came up again at the local user group. So I am thinking is, if custom.css can't be used, what if we change the name to something else for example user.css?

@roland-d roland-d reopened this Jan 20, 2015

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Jan 20, 2015

Contributor

Is the only problem the name custom.css?
If so then I would go with local.css or user.css
Seems easy enough

Contributor

brianteeman commented Jan 20, 2015

Is the only problem the name custom.css?
If so then I would go with local.css or user.css
Seems easy enough

@roland-d

This comment has been minimized.

Show comment
Hide comment
@roland-d

roland-d Jan 20, 2015

Contributor

From what I understand what @infograf768 wrote it is indeed the name custom.css that is the problem here. Can you confirm @infograf768 ?

Contributor

roland-d commented Jan 20, 2015

From what I understand what @infograf768 wrote it is indeed the name custom.css that is the problem here. Can you confirm @infograf768 ?

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Jan 20, 2015

Contributor

If thats the case then its an easy and useful addition

Contributor

brianteeman commented Jan 20, 2015

If thats the case then its an easy and useful addition

@dgrammatiko

This comment has been minimized.

Show comment
Hide comment
@dgrammatiko

dgrammatiko Jan 20, 2015

Member

@roland-d May I propose another way to solve this problem?
Here is my thought:
Introduce an empty less file e.g. isis/less/user.less
Edit template.less to include this new file at the end (same for the rtl)
Provide a button on the backend so admin can recreate the template.css, template-rtl.css

This way we will not introduce one more http request and users can always get some custom css served!

Member

dgrammatiko commented Jan 20, 2015

@roland-d May I propose another way to solve this problem?
Here is my thought:
Introduce an empty less file e.g. isis/less/user.less
Edit template.less to include this new file at the end (same for the rtl)
Provide a button on the backend so admin can recreate the template.css, template-rtl.css

This way we will not introduce one more http request and users can always get some custom css served!

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Jan 20, 2015

Contributor

Thats not a good idea. Running the less compiler on a live " low resourced
shared" server is a guaranteed way to kill your account.

On 20 January 2015 at 22:12, Dimitris Grammatiko notifications@github.com
wrote:

@roland-d https://github.com/roland-d May I propose another way to
solve this problem?
Here is my thought:
Introduce an empty less file e.g. isis/less/user.less
Edit template.less to include this new file at the end (same for the rtl)
Provide a button on the backend so admin can recreate the template.css,
template-rtl.css

This way we will not introduce one more http request and users can always
get some custom css served!


Reply to this email directly or view it on GitHub
#4211 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Contributor

brianteeman commented Jan 20, 2015

Thats not a good idea. Running the less compiler on a live " low resourced
shared" server is a guaranteed way to kill your account.

On 20 January 2015 at 22:12, Dimitris Grammatiko notifications@github.com
wrote:

@roland-d https://github.com/roland-d May I propose another way to
solve this problem?
Here is my thought:
Introduce an empty less file e.g. isis/less/user.less
Edit template.less to include this new file at the end (same for the rtl)
Provide a button on the backend so admin can recreate the template.css,
template-rtl.css

This way we will not introduce one more http request and users can always
get some custom css served!


Reply to this email directly or view it on GitHub
#4211 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@dgrammatiko

This comment has been minimized.

Show comment
Hide comment
@dgrammatiko

dgrammatiko Jan 20, 2015

Member

@brianteeman The less compiler will be required to run only once, I didn’t mean "run less compiler for every request". But anyhow I haven’t benchmark this, so you might be right.

Member

dgrammatiko commented Jan 20, 2015

@brianteeman The less compiler will be required to run only once, I didn’t mean "run less compiler for every request". But anyhow I haven’t benchmark this, so you might be right.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Jan 20, 2015

Contributor

I understand you but users will make a change- compile make a change -
compile make a change - compile etct - trust me - seen it happen too often
on too many sites - it kills poor hosts

On 20 January 2015 at 22:25, Dimitris Grammatiko notifications@github.com
wrote:

@brianteeman https://github.com/brianteeman The less compiler will be
required to run only once, I didn’t mean "run less compiler for every
request". But anyhow I haven’t benchmark this, so you might be right.


Reply to this email directly or view it on GitHub
#4211 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Contributor

brianteeman commented Jan 20, 2015

I understand you but users will make a change- compile make a change -
compile make a change - compile etct - trust me - seen it happen too often
on too many sites - it kills poor hosts

On 20 January 2015 at 22:25, Dimitris Grammatiko notifications@github.com
wrote:

@brianteeman https://github.com/brianteeman The less compiler will be
required to run only once, I didn’t mean "run less compiler for every
request". But anyhow I haven’t benchmark this, so you might be right.


Reply to this email directly or view it on GitHub
#4211 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Jan 21, 2015

Contributor

I still don't see what the problem is we're trying to solve. There are various extensions on JED which allow to do just that. And they are all better than what we would do here.

Contributor

Bakual commented Jan 21, 2015

I still don't see what the problem is we're trying to solve. There are various extensions on JED which allow to do just that. And they are all better than what we would do here.

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Jan 21, 2015

Member

From what I understand what @infograf768 wrote it is indeed the name custom.css that is the problem here. Can you confirm @infograf768 ?

yep.

There are various extensions on JED which allow to do just that. And they are all better than what we would do here.

There are indeed quite a few in
http://extensions.joomla.org/category/style-a-design/templating

Member

infograf768 commented Jan 21, 2015

From what I understand what @infograf768 wrote it is indeed the name custom.css that is the problem here. Can you confirm @infograf768 ?

yep.

There are various extensions on JED which allow to do just that. And they are all better than what we would do here.

There are indeed quite a few in
http://extensions.joomla.org/category/style-a-design/templating

@roland-d

This comment has been minimized.

Show comment
Hide comment
@roland-d

roland-d Jan 21, 2015

Contributor

I still don't see what the problem is we're trying to solve.

The problem is that users can't add their own CSS styling to Protostar without having to use a 3PD extension or hack the Protostar template. The majority of templates have such an option and it is almost standard to have a custom css file users can edit.

And they are all better than what we would do here.

I think we can offer the simplicity of custom css file, if users want more they can use an extension. Having to use an extension for a 4 line change seems overkill to me.

Contributor

roland-d commented Jan 21, 2015

I still don't see what the problem is we're trying to solve.

The problem is that users can't add their own CSS styling to Protostar without having to use a 3PD extension or hack the Protostar template. The majority of templates have such an option and it is almost standard to have a custom css file users can edit.

And they are all better than what we would do here.

I think we can offer the simplicity of custom css file, if users want more they can use an extension. Having to use an extension for a 4 line change seems overkill to me.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Jan 21, 2015

Contributor

Agree. Were spending more time discussing it than it will take to
write,tear,document and comit
On 21 Jan 2015 09:09, "RolandD" notifications@github.com wrote:

I still don't see what the problem is we're trying to solve.

The problem is that users can't add their own CSS styling to Protostar
without having to use a 3PD extension or hack the Protostar template. The
majority of templates have such an option and it is almost standard to have
a custom css file users can edit.

And they are all better than what we would do here.

I think we can offer the simplicity of custom css file, if users want more
they can use an extension. Having to use an extension for a 4 line change
seems overkill to me.


Reply to this email directly or view it on GitHub
#4211 (comment).

Contributor

brianteeman commented Jan 21, 2015

Agree. Were spending more time discussing it than it will take to
write,tear,document and comit
On 21 Jan 2015 09:09, "RolandD" notifications@github.com wrote:

I still don't see what the problem is we're trying to solve.

The problem is that users can't add their own CSS styling to Protostar
without having to use a 3PD extension or hack the Protostar template. The
majority of templates have such an option and it is almost standard to have
a custom css file users can edit.

And they are all better than what we would do here.

I think we can offer the simplicity of custom css file, if users want more
they can use an extension. Having to use an extension for a 4 line change
seems overkill to me.


Reply to this email directly or view it on GitHub
#4211 (comment).

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Jan 21, 2015

Member

Anyhow, we would also need a rtl one I guess.
And the name anyway should be changed.

Member

infograf768 commented Jan 21, 2015

Anyhow, we would also need a rtl one I guess.
And the name anyway should be changed.

@roland-d

This comment has been minimized.

Show comment
Hide comment
@roland-d

roland-d Jan 21, 2015

Contributor

I will update the PR with the needed changes.

Contributor

roland-d commented Jan 21, 2015

I will update the PR with the needed changes.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Feb 4, 2015

Contributor

Are the travis errors on this PR related to the PR or the Unit Tests


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4211.

Contributor

brianteeman commented Feb 4, 2015

Are the travis errors on this PR related to the PR or the Unit Tests


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4211.

@roland-d

This comment has been minimized.

Show comment
Hide comment
@roland-d

roland-d Feb 4, 2015

Contributor

@brianteeman I don't see any errors on this PR?

Contributor

roland-d commented Feb 4, 2015

@brianteeman I don't see any errors on this PR?

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Feb 4, 2015

Contributor

Travis says it fails
On 4 Feb 2015 15:05, "RolandD" notifications@github.com wrote:

@brianteeman https://github.com/brianteeman I don't see any errors on
this PR?


Reply to this email directly or view it on GitHub
#4211 (comment).

Contributor

brianteeman commented Feb 4, 2015

Travis says it fails
On 4 Feb 2015 15:05, "RolandD" notifications@github.com wrote:

@brianteeman https://github.com/brianteeman I don't see any errors on
this PR?


Reply to this email directly or view it on GitHub
#4211 (comment).

@wilsonge

This comment has been minimized.

Show comment
Hide comment
@wilsonge

wilsonge Feb 4, 2015

Contributor

Not the last commit from what i can see. I think you missed the most recent two

Contributor

wilsonge commented Feb 4, 2015

Not the last commit from what i can see. I think you missed the most recent two

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Feb 4, 2015

Contributor

Ah I was going by the one at the top of this page on issues.joomla.org

On 4 February 2015 at 15:15, George Wilson notifications@github.com wrote:

Not the last commit from what i can see. I think you missed the most
recent two


Reply to this email directly or view it on GitHub
#4211 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Contributor

brianteeman commented Feb 4, 2015

Ah I was going by the one at the top of this page on issues.joomla.org

On 4 February 2015 at 15:15, George Wilson notifications@github.com wrote:

Not the last commit from what i can see. I think you missed the most
recent two


Reply to this email directly or view it on GitHub
#4211 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@roland-d

This comment has been minimized.

Show comment
Hide comment
@roland-d

roland-d Feb 4, 2015

Contributor

@brianteeman I wonder if that is a bug of JIssues not updating the status.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4211.

Contributor

roland-d commented Feb 4, 2015

@brianteeman I wonder if that is a bug of JIssues not updating the status.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4211.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Feb 4, 2015

Contributor

Yeah I've raised that as a bug

Contributor

brianteeman commented Feb 4, 2015

Yeah I've raised that as a bug

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Feb 4, 2015

Contributor

@test
Created a user.css using the template manager
Tested it is loaded after template.css
Tested it is not loaded if empty

All good


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4211.

Contributor

brianteeman commented Feb 4, 2015

@test
Created a user.css using the template manager
Tested it is loaded after template.css
Tested it is not loaded if empty

All good


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4211.

@thebeuving

This comment has been minimized.

Show comment
Hide comment
@thebeuving

thebeuving Feb 4, 2015

@test
Created a user.css in the templates/protostar/css directory
loads after template.css
does not load if empty

@test
Created a user.css in the templates/protostar/css directory
loads after template.css
does not load if empty

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Feb 4, 2015

Contributor

Moving RTC thanks for testing. Can someone add the New Feature and RTC label?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4211.

Contributor

zero-24 commented Feb 4, 2015

Moving RTC thanks for testing. Can someone add the New Feature and RTC label?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4211.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Feb 4, 2015

Contributor

Setting RTc - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4211.

Contributor

brianteeman commented Feb 4, 2015

Setting RTc - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4211.

@wilsonge wilsonge added this to the Joomla! 3.5.0 milestone Feb 4, 2015

@ghazal

This comment has been minimized.

Show comment
Hide comment
@ghazal

ghazal Jun 28, 2015

Contributor

Why restrain this new feature to 3.5 ?
Tested in last 3.4.2RC, and it works allright. no big deal either.
As it is said earlier, now, it's common practice among frameworked templates to allow the ability to add a custom.css file to the template.
And, as Brian Teeman says, "So no need for any parameter. If it has content then it is used. If it has no content then it is ignored".
Furthermore, why add a third party extension to perform such a trivial action, very useful though.
To make it short, I think It would be a very nice addition to J!3.4.2

Contributor

ghazal commented Jun 28, 2015

Why restrain this new feature to 3.5 ?
Tested in last 3.4.2RC, and it works allright. no big deal either.
As it is said earlier, now, it's common practice among frameworked templates to allow the ability to add a custom.css file to the template.
And, as Brian Teeman says, "So no need for any parameter. If it has content then it is used. If it has no content then it is ignored".
Furthermore, why add a third party extension to perform such a trivial action, very useful though.
To make it short, I think It would be a very nice addition to J!3.4.2

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Jun 28, 2015

Contributor

Why restrain this new feature to 3.5 ?

Because according to SemVer, new features require a new minor version. So it will be 3.5. No big deal either 😄

Contributor

Bakual commented Jun 28, 2015

Why restrain this new feature to 3.5 ?

Because according to SemVer, new features require a new minor version. So it will be 3.5. No big deal either 😄

@mbabker

This comment has been minimized.

Show comment
Hide comment
@mbabker

mbabker Jul 11, 2015

Member

Merged to 3.5-dev via 1f16717

Member

mbabker commented Jul 11, 2015

Merged to 3.5-dev via 1f16717

@mbabker mbabker closed this Jul 11, 2015

@zero-24 zero-24 removed the RTC label Oct 14, 2015

roland-d added a commit that referenced this pull request Oct 24, 2015

Merge pull request #7621 from zero-24/usercss_beez
[3.5] [imp] Add the ability to use a custom CSS file with beez3 & make the other similiar checks consistend see #4211
@haya1300

This comment has been minimized.

Show comment
Hide comment
@haya1300

haya1300 Nov 9, 2015

I prefer custom.css instead of user.css because in all documentation on the internet or in pdf docs there it is called custom.css. If you want to have properly documentation you must add this exception for the Protostar template in the documentation.
Also plenty Joomla users who are using the custom.css of the Protostar template on their website(s) it will not functioning any more and it must be adjusted after an upgrade to Joomla 3.5
Off course it can be fixed easily but that is not user-friendly.
This is the reason why I should prefer to call it custom.css

haya1300 commented Nov 9, 2015

I prefer custom.css instead of user.css because in all documentation on the internet or in pdf docs there it is called custom.css. If you want to have properly documentation you must add this exception for the Protostar template in the documentation.
Also plenty Joomla users who are using the custom.css of the Protostar template on their website(s) it will not functioning any more and it must be adjusted after an upgrade to Joomla 3.5
Off course it can be fixed easily but that is not user-friendly.
This is the reason why I should prefer to call it custom.css

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Nov 9, 2015

Contributor

@haya1300

Also plenty Joomla users who are using the custom.css of the Protostar template on their website(s) it will not functioning any more and it must be adjusted after an upgrade to Joomla 3.5

No. If it works bevor the update it will work also after the update. (e.g. via Plugin) If you use a core hack to make this work without a template copy this gets reverted every update anyway ;)

Contributor

zero-24 commented Nov 9, 2015

@haya1300

Also plenty Joomla users who are using the custom.css of the Protostar template on their website(s) it will not functioning any more and it must be adjusted after an upgrade to Joomla 3.5

No. If it works bevor the update it will work also after the update. (e.g. via Plugin) If you use a core hack to make this work without a template copy this gets reverted every update anyway ;)

@roland-d

This comment has been minimized.

Show comment
Hide comment
@roland-d

roland-d Nov 10, 2015

Contributor

@haya1300 It is not possible to use the name custom.css because Tinymce will otherwise use the file and apply the CSS style to your editor window.

If you want to have properly documentation you must add this exception for the Protostar template in the documentation.

It doesn't have to be us. Joomla is a community, so you can do it as well.

Contributor

roland-d commented Nov 10, 2015

@haya1300 It is not possible to use the name custom.css because Tinymce will otherwise use the file and apply the CSS style to your editor window.

If you want to have properly documentation you must add this exception for the Protostar template in the documentation.

It doesn't have to be us. Joomla is a community, so you can do it as well.

@jjsjjs

This comment has been minimized.

Show comment
Hide comment
@jjsjjs

jjsjjs Feb 13, 2016

Am i correct that i only have to use/change the index.php to be able to use custom.css ?
Can i use it already in 3.4.8?
If so this is a great feature as i believe Protostar is one of the finest templates around.

jjsjjs commented Feb 13, 2016

Am i correct that i only have to use/change the index.php to be able to use custom.css ?
Can i use it already in 3.4.8?
If so this is a great feature as i believe Protostar is one of the finest templates around.

@wilsonge

This comment has been minimized.

Show comment
Hide comment
@wilsonge

wilsonge Feb 13, 2016

Contributor

No it's going to be in Joomla 3.5 (you can look at the milestone on the right to see what version it will be in) - and it will not require any changes to index.php when it's introduced - you will just need to create your custom CSS file.

Contributor

wilsonge commented Feb 13, 2016

No it's going to be in Joomla 3.5 (you can look at the milestone on the right to see what version it will be in) - and it will not require any changes to index.php when it's introduced - you will just need to create your custom CSS file.

@jjsjjs

This comment has been minimized.

Show comment
Hide comment
@jjsjjs

jjsjjs Feb 13, 2016

ok great!
Thanks

jjsjjs commented Feb 13, 2016

ok great!
Thanks

@N6REJ

This comment has been minimized.

Show comment
Hide comment
@N6REJ

N6REJ Feb 14, 2016

Contributor

You can use a custom.css with any template easily if you install my plugin
http://extensions.joomla.org/extension/jowwow-css-loader

On 2/13/2016 05:27, jjsjjs wrote:

Am i correct that i only have to use/change the index.php to be able
to use custom.css ?
Can i use it already in 3.4.8?
If so this is a great feature as i believe Protostar is one of the
finest templates around.


Reply to this email directly or view it on GitHub
#4211 (comment).

Contributor

N6REJ commented Feb 14, 2016

You can use a custom.css with any template easily if you install my plugin
http://extensions.joomla.org/extension/jowwow-css-loader

On 2/13/2016 05:27, jjsjjs wrote:

Am i correct that i only have to use/change the index.php to be able
to use custom.css ?
Can i use it already in 3.4.8?
If so this is a great feature as i believe Protostar is one of the
finest templates around.


Reply to this email directly or view it on GitHub
#4211 (comment).

@jjsjjs

This comment has been minimized.

Show comment
Hide comment
@jjsjjs

jjsjjs Feb 16, 2016

Thanks a lot :)
I going to check it out right now.

If works ok i will write a review on the extensions page. This would be also a good candidate as a standard item for Joomla ;)
Please update the link to your plugin on the extensions.joomla.org page, thanks. it's a 404

jjsjjs commented Feb 16, 2016

Thanks a lot :)
I going to check it out right now.

If works ok i will write a review on the extensions page. This would be also a good candidate as a standard item for Joomla ;)
Please update the link to your plugin on the extensions.joomla.org page, thanks. it's a 404

@N6REJ

This comment has been minimized.

Show comment
Hide comment
@N6REJ

N6REJ Feb 21, 2016

Contributor

@jjsjjs let me go do that really fast.. idky its not correct.

Contributor

N6REJ commented Feb 21, 2016

@jjsjjs let me go do that really fast.. idky its not correct.

@thebeuving

This comment has been minimized.

Show comment
Hide comment
@thebeuving

thebeuving Feb 21, 2016

I am out of the office February 18th and 19th. If this is an emergency please call me at (209) 217-6400 and leave a voicemail if I don't answer, I will do my best to respond promptly.

I will reply to all non-emergency requests on Monday February 22st.

Thank you,
David Beuving

I am out of the office February 18th and 19th. If this is an emergency please call me at (209) 217-6400 and leave a voicemail if I don't answer, I will do my best to respond promptly.

I will reply to all non-emergency requests on Monday February 22st.

Thank you,
David Beuving

@N6REJ

This comment has been minimized.

Show comment
Hide comment
@N6REJ

N6REJ Feb 21, 2016

Contributor

@jjsjjs updated

Contributor

N6REJ commented Feb 21, 2016

@jjsjjs updated

@jjsjjs

This comment has been minimized.

Show comment
Hide comment
@jjsjjs

jjsjjs Feb 21, 2016

Thanks Bear! Great plug-in. Worked instantly, no hasle. I will write a review this week on the extensions page under the pseudoname idnib (haha it's the reverse of my daughter's name)

jjsjjs commented Feb 21, 2016

Thanks Bear! Great plug-in. Worked instantly, no hasle. I will write a review this week on the extensions page under the pseudoname idnib (haha it's the reverse of my daughter's name)

@N6REJ

This comment has been minimized.

Show comment
Hide comment
@N6REJ

N6REJ Feb 22, 2016

Contributor

Thanks... its been a long time since I updated it but it does everything
I can reasonably want it to do and now with the ability to add css file
right from within the template manager I dont' see the urgent need to
change it.
Bear

On 2/21/2016 15:58, jjsjjs wrote:

Thanks Bear! Great plug-in. Worked instantly, no hasle. I will write a
review this week on the extensions page under the pseudoname idnib
(haha it's the reverse of my daughter's name)


Reply to this email directly or view it on GitHub
#4211 (comment).

Contributor

N6REJ commented Feb 22, 2016

Thanks... its been a long time since I updated it but it does everything
I can reasonably want it to do and now with the ability to add css file
right from within the template manager I dont' see the urgent need to
change it.
Bear

On 2/21/2016 15:58, jjsjjs wrote:

Thanks Bear! Great plug-in. Worked instantly, no hasle. I will write a
review this week on the extensions page under the pseudoname idnib
(haha it's the reverse of my daughter's name)


Reply to this email directly or view it on GitHub
#4211 (comment).

@wilsonge

This comment has been minimized.

Show comment
Hide comment
@wilsonge

wilsonge Feb 22, 2016

Contributor

Guys this isn't the place to be talking about 3rd party plugins ;) Please take it off this thread :)

Contributor

wilsonge commented Feb 22, 2016

Guys this isn't the place to be talking about 3rd party plugins ;) Please take it off this thread :)

@N6REJ

This comment has been minimized.

Show comment
Hide comment
@N6REJ

N6REJ Feb 23, 2016

Contributor

just close the ticket george

On 2/22/2016 14:41, George Wilson wrote:

Guys this isn't the place to be talking about 3rd party plugins ;)
Please take it off this thread :)


Reply to this email directly or view it on GitHub
#4211 (comment).

Contributor

N6REJ commented Feb 23, 2016

just close the ticket george

On 2/22/2016 14:41, George Wilson wrote:

Guys this isn't the place to be talking about 3rd party plugins ;)
Please take it off this thread :)


Reply to this email directly or view it on GitHub
#4211 (comment).

@wilsonge

This comment has been minimized.

Show comment
Hide comment
@wilsonge

wilsonge Feb 23, 2016

Contributor

It's been closed since August ;)

Contributor

wilsonge commented Feb 23, 2016

It's been closed since August ;)

@joomla joomla locked and limited conversation to collaborators Feb 23, 2016

@roland-d roland-d deleted the roland-d:protostar-custom branch Apr 13, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.