Skip to content

[5.1] Use Dialog for Batch for Redirect component#42355

Merged
LadySolveig merged 4 commits into
joomla:5.1-devfrom
Fedik:popup-batch3
Jan 30, 2024
Merged

[5.1] Use Dialog for Batch for Redirect component#42355
LadySolveig merged 4 commits into
joomla:5.1-devfrom
Fedik:popup-batch3

Conversation

@Fedik
Copy link
Copy Markdown
Member

@Fedik Fedik commented Nov 16, 2023

Summary of Changes

Use Dialog for Batch for Redirect component.
I somehow forgot it in previous PR #42328

Testing Instructions

Use "Bulk Import" button to import an urls in Redirect component.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Nov 16, 2023

I have tested this item ✅ successfully on 0f3a32c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42355.

1 similar comment
@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 0f3a32c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42355.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Nov 16, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42355.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 16, 2023
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Jan 5, 2024
@LadySolveig
Copy link
Copy Markdown
Contributor

Could you resolve the conflict here please :) @Fedik

 Conflicts:
	administrator/components/com_redirect/tmpl/links/emptystate.php
@LadySolveig LadySolveig merged commit a1cdbc1 into joomla:5.1-dev Jan 30, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 30, 2024
@LadySolveig
Copy link
Copy Markdown
Contributor

Thank you @Fedik and for testing @Quy @viocassel

@Fedik Fedik deleted the popup-batch3 branch January 30, 2024 21:21
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 10, 2024
richard67 added a commit to richard67/joomla-cms that referenced this pull request Feb 10, 2024
LadySolveig pushed a commit that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants