Skip to content

Conversation

@bembelimen
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR adds a "Generic" schema.org type which offers a JSON field to add any schema.org JSON-LD.

Testing Instructions

  • Apply the PR
  • Go to an article (or create one)
  • Setup the schema.org plugin once
  • Select "Generic" as Schema Type
    grafik
  • Add any valid JSON-LD string to the JSON field
  • Save
  • Open article in frontend
  • Check browser source code
  • Check page with https://search.google.com/test/rich-results

Actual result BEFORE applying this Pull Request

No Generic type available

Expected result AFTER applying this Pull Request

Generic type available

@brianteeman
Copy link
Contributor

Please update libraries\src\Extension\ExtensionHelper

@brianteeman
Copy link
Contributor

I think a better name for this plugin would be Custom and not Generic

Generic means it is something suitable for everything
Custom means it is something unique and specific

But its a close call and probably something lost in translation anyway

bembelimen and others added 2 commits January 23, 2024 10:53
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
@bembelimen
Copy link
Contributor Author

Thanks @LadySolveig

@Hackwar Hackwar added Feature PBF Pizza, Bugs and Fun labels Feb 20, 2024
@crommie
Copy link

crommie commented Feb 24, 2024

I have tested this item 🔴 unsuccessfully on 53793d0

No generic schema type available after applying patch. Maybe I'm just not good at following instructions?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42699.

@devcodemonkey
Copy link

I have tested this item ✅ successfully on 53793d0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42699.

@crommie
Copy link

crommie commented Feb 24, 2024

I have tested this item ✅ successfully on 9182a05

After I installed 5.1.0 beta 1 + PR 42699 package, everything works as expected.

I activated the plugin, opened an article, selected Custom (no longer "generic") and pasted the above valid JSON code.
No errors, everything fine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42699.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.1.0 milestone Feb 24, 2024
@bembelimen
Copy link
Contributor Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42699.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 24, 2024
@richard67
Copy link
Member

@bembelimen The update SQL scripts need to be renamed from "5.1.0-2024-01-18.sql" to something newer than "5.1.0-2024-02-10.sql", which is the latest update SQL at the moment in the 5.1-dev branch, otherwise they will not run when updating from 5.1.0-alpha4 to beta1. I suggest to use "5.1.0-2024-02-25.sql", as "5.1.0-2024-02-24.sql" is already used by another PR.

It won't need new human tests after that. But the PR should not be merged as it is.

@richard67 richard67 added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Feb 24, 2024
@richard67
Copy link
Member

P.S.: Or let me know if I shall do that for you, rename the update SQL scripts.

@bembelimen
Copy link
Contributor Author

bembelimen commented Feb 24, 2024

Thanks for the find @richard67 I have changed it!

@richard67 richard67 removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Feb 24, 2024
@LadySolveig LadySolveig merged commit ae47b89 into joomla:5.1-dev Feb 25, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 25, 2024
@LadySolveig
Copy link
Contributor

Thank you @bembelimen 🚀 and for the diligent testers and support @brianteeman @chmst @Quy @crommie @devcodemonkey @richard67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Language Change This is for Translators PBF Pizza, Bugs and Fun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants