-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.1] Schemaorg => Generic plugin #42699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Schemaorg => Generic plugin #42699
Conversation
|
Please update |
|
I think a better name for this plugin would be Custom and not Generic Generic means it is something suitable for everything But its a close call and probably something lost in translation anyway |
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
|
Thanks @LadySolveig |
|
I have tested this item 🔴 unsuccessfully on 53793d0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42699. |
|
I have tested this item ✅ successfully on 53793d0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42699. |
|
I have tested this item ✅ successfully on 9182a05 I activated the plugin, opened an article, selected Custom (no longer "generic") and pasted the above valid JSON code. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42699. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42699. |
|
@bembelimen The update SQL scripts need to be renamed from "5.1.0-2024-01-18.sql" to something newer than "5.1.0-2024-02-10.sql", which is the latest update SQL at the moment in the 5.1-dev branch, otherwise they will not run when updating from 5.1.0-alpha4 to beta1. I suggest to use "5.1.0-2024-02-25.sql", as "5.1.0-2024-02-24.sql" is already used by another PR. It won't need new human tests after that. But the PR should not be merged as it is. |
|
P.S.: Or let me know if I shall do that for you, rename the update SQL scripts. |
|
Thanks for the find @richard67 I have changed it! |
|
Thank you @bembelimen 🚀 and for the diligent testers and support @brianteeman @chmst @Quy @crommie @devcodemonkey @richard67 |
Pull Request for Issue # .
Summary of Changes
This PR adds a "Generic" schema.org type which offers a JSON field to add any schema.org JSON-LD.
Testing Instructions
Actual result BEFORE applying this Pull Request
No Generic type available
Expected result AFTER applying this Pull Request
Generic type available