Convert mod_messages to service provider#42735
Merged
LadySolveig merged 14 commits intojoomla:5.1-devfrom Feb 27, 2024
Merged
Conversation
richard67
reviewed
Jan 31, 2024
administrator/modules/mod_messages/src/Dispatcher/Dispatcher.php
Outdated
Show resolved
Hide resolved
sandewt
reviewed
Jan 31, 2024
administrator/modules/mod_messages/src/Helper/MessagesHelper.php
Outdated
Show resolved
Hide resolved
sandewt
reviewed
Jan 31, 2024
sandewt
reviewed
Jan 31, 2024
administrator/modules/mod_messages/src/Dispatcher/Dispatcher.php
Outdated
Show resolved
Hide resolved
|
I have tested this item ✅ successfully on 24ba818 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735. |
Member
|
@joomlaweby No need to update your branch when there are no conflicts shown. Updating the branch in validates the test counter for human test. I've restored the result from @fgsw now so it's counted again. |
Contributor
Author
|
Contributor
|
I have tested this item ✅ successfully on 769c4ab This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735. |
|
Tested successfully during PBF 2024. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735. |
Contributor
|
Thank you @joomlaweby and also for testing and support @fgsw @viocassel @exlemor @richard67 @sandewt |
heelc29
added a commit
to heelc29/joomla-cms
that referenced
this pull request
Feb 27, 2024
fix return value
heelc29
added a commit
to heelc29/joomla-cms
that referenced
this pull request
Feb 27, 2024
fix return value
bembelimen
pushed a commit
that referenced
this pull request
Feb 29, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Converts the messages administrator module to service provider.
This is my first pull request to Joomla! project :-).
Testing Instructions
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed