Skip to content

Conversation

@C-Lodder
Copy link
Member

@C-Lodder C-Lodder commented Feb 4, 2024

Summary of Changes

This PR fixes error validation on a "User" field when a user is selected.

Testing Instructions

  1. Got to administrator/index.php?option=com_messages&view=messages
  2. Click "New"
  3. Focus on the "Recipient" user input field
  4. Focus away from the "Recipient" user input field (you'll see a red error message)
  5. Select a user

Actual result BEFORE applying this Pull Request

Field remained red with the error message

Expected result AFTER applying this Pull Request

Error message is removed and field border turns green

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Feb 4, 2024
@dgrammatiko
Copy link
Contributor

I wouldn't add another listener into the validate.js.
FWIW you can fix this issue by replacing this

dialog.addEventListener('joomla-dialog:close', () => {
window.removeEventListener('message', msgListener);
dialog.destroy();
this.dialog = null;
});

with this:

    dialog.addEventListener('joomla-dialog:close', () => {
      window.removeEventListener('message', msgListener);
      dialog.destroy();
      this.dialog = null;
      this.inputName.focus();
      this.buttonSelect.focus();
    });

Basically it's a focus delegation problem...

@ghost
Copy link

ghost commented Feb 5, 2024

I have tested this item ✅ successfully on 57babee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 0dabe82


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.

1 similar comment
@ghost
Copy link

ghost commented Feb 6, 2024

I have tested this item ✅ successfully on 0dabe82


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.

@Quy
Copy link
Contributor

Quy commented Feb 6, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 6, 2024
@crimle
Copy link

crimle commented Feb 24, 2024

I have tested this item 🔴 unsuccessfully on dc0db7f

Pressing the button {Apply Patch] results in error message
There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.

@Nuyonuyonoina
Copy link

Nuyonuyonoina commented Feb 24, 2024

"Apply patch" button doesn't work. Error message is "There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation."

@eddiekonczal
Copy link

I have tested this item 🔴 unsuccessfully on dc0db7f

When I try to install the patch, I get this error:

"There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation."


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42756.

@richard67
Copy link
Member

richard67 commented Feb 25, 2024

@crimle @Nuyonuyonoina @eddiekonczal I will reset the negative test results as they are not caused by this PR. The PR modifies an NPM dependency, which can be seen by the label "NPM Resource Changed". Such PRs can't be tested with Patchtester, they require either a development environment with composer and NPM, or they need to be applied by using the packages created by drone, which can be found in the "Downloads" section of the integration checks at the bottom of the PR.

@bembelimen bembelimen merged commit cc8ef4d into joomla:5.1-dev Feb 25, 2024
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 25, 2024
@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Feb 25, 2024
@C-Lodder C-Lodder deleted the user-field-validation branch September 24, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.