Skip to content

Conversation

@C-Lodder
Copy link
Member

@C-Lodder C-Lodder commented Feb 7, 2024

Summary of Changes

This PR addresses two items:

  1. Two of the toolbar buttons ("Save Target" and "Copy Reference to Target") were missing an ID and therefore were not hidden as the JS couldn't find them.
  2. Remove the jQuery dependency for the com_associations sidebyside JS

Testing Instructions

  1. Ensure you have a multilingual site setup.
  2. Play around with com_associations and make sure it's all working as expected.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Feb 7, 2024
@ghost
Copy link

ghost commented Feb 8, 2024

@C-Lodder please inform when the PR is ready for test.

@C-Lodder
Copy link
Member Author

C-Lodder commented Feb 8, 2024

@fgsw It's ready now

@ghost
Copy link

ghost commented Feb 8, 2024

I have tested this item ✅ successfully on be13537


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42771.

@Fedik
Copy link
Member

Fedik commented Feb 8, 2024

@C-Lodder I see you are brave man.
The whole thing is asking for a good refactoring, but moving away from jquery, at least something.
Thanks!

And please keep old copyright date, in the end it the same sidebyside.js

@Fedik Fedik added the Feature label Feb 8, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 9, 2024
@LadySolveig LadySolveig merged commit d67ea51 into joomla:5.1-dev Feb 24, 2024
@LadySolveig
Copy link
Contributor

Thank you @C-Lodder and also for testing and review @fgsw @Fedik @laoneo @dgrammatiko

@C-Lodder C-Lodder deleted the associations-js branch September 24, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants