[4.4] Fix help icon not opening help screen

[Quy]

Pull Request for Issue #42818 .

Summary of Changes

Help icon fails to open help screen when clicked on the question mark.

Thanks @dgrammatiko for the solution.

Testing Instructions

Go to any screen which has a help screen, for example Content -> Articles.
Click on the text "Help" of the help toolbar button and you will see the appropriate help screen. However, if you click on the question mark to the left of the text you will get a much larger blank window with "about:blank" in the address bar.

Download the prebuilt package.
or
Apply PR and run npm run build:js

[ChristineWk]

I have tested this item ✅ successfully on 7a13d66

with NPM Prebuilt Package

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42820.}

[viocassel]

I have tested this item ✅ successfully on 7a13d66

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42820.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42820.}

[C-Lodder]

Please don't use CSS to fix a JS problem

You should be using currentTarget, rather than target instead:

https://github.com/joomla/joomla-cms/blob/4.4-dev/build/media_source/legacy/js/toolbar.es5.js#L46

E.g you want to target the element that the event is attached to (button), rather than trying to target the element that you clicked, which in this case (the icon), has no event attached to it.

[C-Lodder]

I have tested this item ✅ successfully on 92a1cf4

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42820.}

[viocassel]

I have tested this item ✅ successfully on 92a1cf4

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42820.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42820.}