Skip to content

[5.1] Convert mod_stats_admin to service provider #42886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 26, 2024

Conversation

joomlaweby
Copy link
Contributor

Summary of Changes

Converts the statistics administrator module to service provider.

Testing Instructions

  1. Make sure you have administrator module mod_stats_admin published
  2. You should see module output

mod_stats_admin

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@LadySolveig LadySolveig modified the milestone: Joomla! 5.1.0 Feb 25, 2024
@ghost
Copy link

ghost commented Feb 26, 2024

I have tested this item ✅ successfully on 8ca7a8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42886.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 8ca7a8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42886.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42886.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 26, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 26, 2024
@LadySolveig LadySolveig merged commit a759763 into joomla:5.1-dev Feb 26, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 26, 2024
@LadySolveig
Copy link
Contributor

Thank you @joomlaweby and also for testing @fgsw @viocassel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants