Skip to content

[5.1] Convert mod_post_installation_messages to service provider #42987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 17, 2024

Conversation

joomlaweby
Copy link
Contributor

Summary of Changes

Converts the administrator post installation messages module to service provider.

Testing Instructions

  1. Make sure you have administrator module mod_post_installation_messages published and have some not hidden post installation messages - click on Reset messages button in Post Installation Messages component
  2. You should see module output in administrator area

mod_post_installation_messages

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@sandewt
Copy link
Contributor

sandewt commented Mar 9, 2024

I have tested this item ✅ successfully on 6a3a01c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42987.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 6a3a01c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42987.

@Quy
Copy link
Contributor

Quy commented Mar 9, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42987.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 9, 2024
@bembelimen bembelimen merged commit 82781ca into joomla:5.1-dev Mar 17, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 17, 2024
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Mar 17, 2024
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 19, 2024
@joomlaweby joomlaweby deleted the mod_post_installation_messages branch January 1, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants