Skip to content

[5.1] Convert mod_login to service provider #42990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 13, 2024

Conversation

joomlaweby
Copy link
Contributor

Summary of Changes

Converts the administrator login module to service provider.

Testing Instructions

  1. You should see module output in administrator login page

mod_login

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@ceford
Copy link
Contributor

ceford commented Mar 11, 2024

I have tested this item ✅ successfully on 1ac8a37


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42990.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 1ac8a37


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42990.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42990.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 11, 2024
@richard67
Copy link
Member

RTC is still valid as the change after that was just small code style change.

@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Mar 13, 2024
@LadySolveig
Copy link
Contributor

Thank you @joomlaweby 🚀 and also for testing and review @ceford @viocassel @sandewt

@LadySolveig LadySolveig merged commit e036481 into joomla:5.1-dev Mar 13, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 13, 2024
@joomlaweby joomlaweby deleted the mod_login branch January 6, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants