Skip to content

[5.2] Allow multiselect for checkboxes#44500

Merged
Hackwar merged 2 commits intojoomla:5.2-devfrom
Digital-Peak:multiselect
Nov 27, 2024
Merged

[5.2] Allow multiselect for checkboxes#44500
Hackwar merged 2 commits intojoomla:5.2-devfrom
Digital-Peak:multiselect

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Nov 21, 2024

Summary of Changes

Restores multiselect behavior when SHIFT key is pressed in back end list views.

Testing Instructions

  • Create 5 articles in the back end.
  • Select the first one in the list
  • Hold SHIFT key and select the last one

Actual result BEFORE applying this Pull Request

First and last one is selected and the text in between.

Expected result AFTER applying this Pull Request

All articles are selected and no text.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Nov 21, 2024
@ghost
Copy link

ghost commented Nov 21, 2024

I have tested this item ✅ successfully on e4ff486

Test by using prebuilt package.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44500.

@LadySolveig
Copy link
Contributor

I have tested this item ✅ successfully on e4ff486


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44500.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on c8ee38c

thank you!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44500.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on c8ee38c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44500.

@Quy
Copy link
Contributor

Quy commented Nov 21, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44500.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 21, 2024
@Hackwar Hackwar added the bug label Nov 23, 2024
@Hackwar Hackwar merged commit 6a66618 into joomla:5.2-dev Nov 27, 2024
@Hackwar Hackwar added this to the Joomla! 5.2.3 milestone Nov 27, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 27, 2024
@Hackwar
Copy link
Member

Hackwar commented Nov 27, 2024

Thank you for your contribution!

@laoneo laoneo deleted the multiselect branch November 28, 2024 09:08
heelc29 added a commit to heelc29/joomla-cms that referenced this pull request Jan 10, 2025
laoneo pushed a commit that referenced this pull request Jan 15, 2025
* [5.2] system test for list multiselect (PR #44500)

* add test for articles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants