Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Regression: We can't remove the URL-Parameter "limitstart" #4488
In some extensions the user can't get back to the first page once he navigated to a later page.
If an extension uses
This PR just reverts the faulty PR and restores the limitstart parameter.
As this doesn't happen with core extensions, you need to use a 3rd party extension which is affected. You can use my own "SermonSpeaker" to do that. Either install it using the webinstaller or get it from http://www.sermonspeaker.net/download/sermonspeaker-component/sermonspeaker-component-5-2-3.html.
Tested on a fresh install of 3.3.6 with limit set to 5. 10 articles - tested for features listing and category listings with pagination and all worked fine. Installed my component with parent::populateState in the model and pagination worked fine as well. Thanks again. Cheers.
@test I have tested it with kunena, it works.
Results without patch:
Page 1: forum/recent
You can't navigate back to first page.
Results with patch:
Page 1: forum/recent?limitstart=0
You can navigate on all pages
This "fix" means, that now the first page of every list has 2 URLs. "whatever" and "whatever?limitstart=0". At the same time, limitstart was always renamed to start in our URLs. please revert this. It is not the solution to the problem. The problem is in the code in JModelList::populateState().