Skip to content

[6.0] Replace dialog GIF loader with SVG loader - #45097

Merged
softforge merged 2 commits into
joomla:6.0-devfrom
Fedik:dialog-loader
Mar 11, 2025
Merged

[6.0] Replace dialog GIF loader with SVG loader#45097
softforge merged 2 commits into
joomla:6.0-devfrom
Fedik:dialog-loader

Conversation

@Fedik

@Fedik Fedik commented Mar 8, 2025

Copy link
Copy Markdown
Member

Pull Request for Issue #44232 .

Summary of Changes

Alternative to #44232

Testing Instructions

Please follow #44232

Actual result BEFORE applying this Pull Request

Loader looks not very good

Expected result AFTER applying this Pull Request

Loader looks good

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.0-dev labels Mar 8, 2025
@Fedik Fedik added the Feature label Mar 8, 2025
@exlemor

exlemor commented Mar 8, 2025

Copy link
Copy Markdown

I have tested this item ✅ successfully on a868df9

I have tested this successfully :). Thanks @Fedik - looks beautiful in Dark Mode :D


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45097.

@krishnagandhicode

Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on a868df9

I have tested this successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45097.

@exlemor

exlemor commented Mar 9, 2025

Copy link
Copy Markdown

Congratulations @krishnaGandhi11 on your first PR test - now you no longer need my help you are good to go on your own. :)

@QuyTon

QuyTon commented Mar 9, 2025

Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45097.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 9, 2025
@brianteeman

Copy link
Copy Markdown
Contributor

Does this resolve the open issues #31078 and #30099

@softforge softforge added this to the Joomla! 6.0.0 milestone Mar 11, 2025
@softforge
softforge merged commit 60fb9c6 into joomla:6.0-dev Mar 11, 2025
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 11, 2025
@softforge

Copy link
Copy Markdown
Contributor

Thanks @Fedik for your work on this and to the testers who put in the time.
Could you please take a look at the comment from Brian
Does this resolve the open issues #31078 and #30099

@Fedik
Fedik deleted the dialog-loader branch March 11, 2025 15:47
@Fedik

Fedik commented Mar 11, 2025

Copy link
Copy Markdown
Member Author

Does this resolve the open issues #31078 and #30099

No, this PR only for Joomla Dialog when "Dark mode" is active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants