Probably typo in default value for $selector #455

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@Bakual

The default classname for the $selector should probably be named "advancedSelect" and not "advandedSelect". I guess it's a typo.

Bakual added some commits Sep 26, 2012
@Bakual Bakual Probably typo in default value for $selector
The default classname for the $selector should probably be named "advancedSelect" and not "advandedSelect". I guess it's a typo.
1e1682d
@Bakual Bakual Changing class from advandedSelect to advancedSelect
Changing class from advandedSelect to advancedSelect. Thanks to Jean-Marie Simonet for pointing that out.
d8aba4a
@Bakual

Added an instance of 'advandedSelect' in the mod_login to the PR.

@infograf768
Joomla! member

Please create a tracker on joomlacode and cross reference here.
Change in class name potentially breaks 3pd extension

@Bakual

Already done, but forgot to back reference: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=29717

I don't think breaking 3party extensions is an issue. For one everyone that really uses "advandedSelect" as a classname probably thinks that must be a typo (like I did) and then 3.0 is still a short term release where exactly such issues are expected to be found and fixed :-)

@mbabker
Joomla! member

Fixed at 91a3a5b

@mbabker mbabker closed this Mar 9, 2013
@Bakual Bakual deleted the Bakual:patch-1 branch Mar 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment