Removing unnecessary run of JRouter::parse() #4614

Merged
merged 1 commit into from Dec 2, 2014

Conversation

Projects
None yet
7 participants
@Hackwar
Member

Hackwar commented Oct 12, 2014

$router->getVars() is a simple lookup of the parsed variables of the current URI and saves A LOT of memory and run time. See #4612 for a similar issue.

@ketchupmonki

This comment has been minimized.

Show comment
Hide comment
@ketchupmonki

ketchupmonki Oct 17, 2014

Tested with and without SEF, on a variety of pages.(Inc. home page.) Patch working.

Didn't test on multi-lingual.

Tested with and without SEF, on a variety of pages.(Inc. home page.) Patch working.

Didn't test on multi-lingual.

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Nov 27, 2014

Contributor

moving RTC since we have two tests one by @ketchupmonki and one by @LarsMog

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4614.

Contributor

zero-24 commented Nov 27, 2014

moving RTC since we have two tests one by @ketchupmonki and one by @LarsMog

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4614.

@brianteeman brianteeman added the RTC label Nov 29, 2014

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Dec 2, 2014

Member

Ok here in multilang.

Member

infograf768 commented Dec 2, 2014

Ok here in multilang.

infograf768 added a commit that referenced this pull request Dec 2, 2014

Merge pull request #4614 from Hackwar/loginurl
Removing unnecessary run of JRouter::parse()

@infograf768 infograf768 merged commit 3ff64a6 into joomla:staging Dec 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@Bakual Bakual added this to the Joomla! 3.4.0 milestone Dec 2, 2014

@Hackwar Hackwar deleted the Hackwar:loginurl branch Dec 10, 2014

@zero-24 zero-24 removed the RTC label Oct 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment