Routing: Adding application and menu objects to component routers #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems good here.Massive +1 for DI of the JApp object etc |
|
Tested, all seems good. |
|
You guys trying to make me happy? 😄 |
pmorrisarctg
added a commit
to ArcTechnologyGroup/joomla-cms
that referenced
this pull request
Nov 26, 2014
staging # By Michael Babker (143) and others # Via infograf768 (131) and others * 'staging' of https://github.com/joomla/joomla-cms: (1128 commits) Fixed typo introduced on PR joomla#4308 Fixed missing space Correcting comments [fix joomla#5173] JRouterInstallation::build() strict standards trim the author and created_by_alias before saving Remove all \r\n Update en-GB.plg_system_debug.ini JRouterInstallation::parse() made compatible with the interface (Fix joomla#5173) Clean up non-printable characters. Fixed creationDate Fixes Author and Copyright info for Editor - None Routing: Implementing an interface for component router rules (Fix joomla#4849) Routing: Adding application and menu objects to component routers (Fix joomla#4848) Fixing JGithub repository contents api (Fix joomla#5067) [bug] Protostar template doesn't work with component links in SEF. Fixes joomla#5085 Fix undefined variable in Article Model ... use the right variable, dummy. fix the codemirror display bug, happens when codemirror is initialized in a hidden element. Use the created_by_alias in the author meta tag. This is consistent with how author name is show elsewhere. [fix] Broken groups management by joomla#4308 ... Conflicts: installation/sql/sqlazure/sample_blog.sql installation/sql/sqlazure/sample_testing.sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routers in Joomla should be testable in the future with unittests. Right now, they heavily depend on JFactory and some not-so-nice code constructs to work. In order to introduce dependency injection, this PR hands over the application and the menu to the component routers. This means that you can inject fake application objects and menus into the router during testing. At the same time, component routers can build lookup tables once when they are instantiated and can get their input through these 2 objects.
This is backwards compatible, since additional arguments for a method/constructor are simply ignored by PHP and since we didn't have any arguments up to this point for the constructor, this has no effect so far.
In the future, the application router should get something similar in order to make the whole process testable. For the moment, the Singletons are still used.
Testing instructions: Set the error_reporting in Joomlas global configuration to maximum, check any errors/notices/warnings that appear, apply the change and then see that no new errors/notices/warnings showed up.
This is a new, cleaned up PR that relates to #4714.
This was made possible through the generous donation of the people mentioned in the following link via an Indiegogo campaign: http://joomlager.de/crowdfunding/5-contributors