Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFinder: Fallback for routing is called with wrong parameters #5104
Conversation
jissues-bot
added
the
PR-staging
label
Nov 14, 2014
added a commit
that referenced
this pull request
Nov 22, 2014
mbabker
merged commit 1c9f6ee
into
joomla:staging
Nov 22, 2014
1 check passed
continuous-integration/travis-ci
The Travis CI build passed
Details
Hackwar
deleted the
Hackwar:finderroutingfix
branch
Dec 10, 2014
rdeutz
added this to the Joomla! 3.4.0 milestone
Feb 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Hackwar commentedNov 14, 2014
The method ContentHelperRoute::getCategoryRoute() does not have this signature. Instead, it needs to be called the same as in line 300. This needs a maintainer to simply look over this and give this a code-review.