New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving query to use indexes better. Fixes #5101 #5120

Merged
merged 1 commit into from Nov 21, 2014

Conversation

Projects
None yet
5 participants
@Hackwar
Member

Hackwar commented Nov 16, 2014

As hinted at in the table, this fixes #5101
enabled seems to only be toggled between 0 and 1, so if we check for everything greater than 1, we only have one value and then we can simply do a comparison. State equally seems to toggle between 0 and 1, although we don't seem to use it at all... This should be investigated further.

@RCheesley

This comment has been minimized.

RCheesley commented Nov 16, 2014

Happy to test but some guidance would be appreciated.

I've got debug enabled, I can see the queries within debug, but I'm not sure what views I should be looking at (I think maybe plugin manager but not sure?) or what I'm looking for pre- and post- patch. It could be that this just needs to be a code inspection and nothing can be 'seen' to be tested, but if so please can you provide clarification.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5120.

@Hackwar

This comment has been minimized.

Member

Hackwar commented Nov 16, 2014

Hi @RCheesley, yes, this is mainly a question of code review.

@Bakual

This comment has been minimized.

Contributor

Bakual commented Nov 17, 2014

yes, this is mainly a question of code review.

It would be very easy to test if test instructions are present which say where this query is run.

@Hackwar

This comment has been minimized.

Member

Hackwar commented Nov 17, 2014

This query is run on every page and every call to Joomla.

@alikon

This comment has been minimized.

Contributor

alikon commented Nov 21, 2014

explaining the actual query
explain_5120_post

and explaining the PRoposed query
explain_5120_post

as we can see the pr 5120 use index

Bakual added a commit that referenced this pull request Nov 21, 2014

Merge pull request #5120 from Hackwar/extensiontable
Improving query to use indexes better. Fixes #5101

@Bakual Bakual merged commit b73f953 into joomla:staging Nov 21, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@Bakual Bakual added this to the Joomla! 3.4.0 milestone Nov 21, 2014

@Hackwar Hackwar deleted the Hackwar:extensiontable branch Nov 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment