JRouterInstallation::parse() made compatible with the interface #5173

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@Hackwar
Member

Hackwar commented Nov 23, 2014

This fixes #5172. Mea culpa. I missed that & in the Installation router. 馃槃

Testing instructions:
Set PHP error reporting to maximum, try to install Joomla. You will get an error in your Ajax response and the installation does not proceed.
Apply patch and see that this does not happen anymore.

@Hackwar

This comment has been minimized.

Show comment
Hide comment
@Hackwar

Hackwar Nov 23, 2014

Member

Funny thing... That bug was in Joomla since August 2013. Phew, not my fault. Dodged that bullet. 馃槈

Member

Hackwar commented Nov 23, 2014

Funny thing... That bug was in Joomla since August 2013. Phew, not my fault. Dodged that bullet. 馃槈

@mbabker

This comment has been minimized.

Show comment
Hide comment
@mbabker

mbabker Nov 23, 2014

Member

Merged on review

Member

mbabker commented Nov 23, 2014

Merged on review

@mbabker mbabker closed this in 121e645 Nov 23, 2014

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Nov 25, 2014

Member

[25-Nov-2014 09:47:40 UTC] PHP Strict standards: Declaration of JRouterInstallation::build() should be compatible with JRouter::build($url) in /Applications/MAMP/htdocs/testnew/trunkgitnew/installation/application/router.php on line 47

Member

infograf768 commented Nov 25, 2014

[25-Nov-2014 09:47:40 UTC] PHP Strict standards: Declaration of JRouterInstallation::build() should be compatible with JRouter::build($url) in /Applications/MAMP/htdocs/testnew/trunkgitnew/installation/application/router.php on line 47

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Nov 25, 2014

Member

Looks like you corrected parse, but broke build

Member

infograf768 commented Nov 25, 2014

Looks like you corrected parse, but broke build

@infograf768

This comment has been minimized.

Show comment
Hide comment
@infograf768

infograf768 Nov 25, 2014

Member

Please test
#5198

Member

infograf768 commented Nov 25, 2014

Please test
#5198

Bakual added a commit that referenced this pull request Nov 25, 2014

Merge pull request #5198 from infograf768/(fix5173)
[fix #5173] JRouterInstallation::build() strict standards

pmorrisarctg added a commit to ArcTechnologyGroup/joomla-cms that referenced this pull request Nov 26, 2014

Merge branch 'staging' of https://github.com/joomla/joomla-cms into
staging

# By Michael Babker (143) and others
# Via infograf768 (131) and others
* 'staging' of https://github.com/joomla/joomla-cms: (1128 commits)
  Fixed typo introduced on PR #4308
  Fixed missing space
  Correcting comments
  [fix #5173] JRouterInstallation::build() strict standards
  trim the author and created_by_alias before saving
  Remove all \r\n
  Update en-GB.plg_system_debug.ini
  JRouterInstallation::parse() made compatible with the interface (Fix
#5173)
  Clean up non-printable characters.
  Fixed creationDate
  Fixes Author and Copyright info for Editor - None
  Routing: Implementing an interface for component router rules (Fix
#4849)
  Routing: Adding application and menu objects to component routers (Fix
#4848)
  Fixing JGithub repository contents api (Fix #5067)
  [bug] Protostar template doesn't work with component links in SEF.
Fixes #5085
  Fix undefined variable in Article Model
  ... use the right variable, dummy.
  fix the codemirror display bug, happens when codemirror is initialized
in a hidden element.
  Use the created_by_alias in the author meta tag. This is consistent
with how author name is show elsewhere.
  [fix] Broken groups management by #4308
  ...

Conflicts:
	installation/sql/sqlazure/sample_blog.sql
	installation/sql/sqlazure/sample_testing.sql

@Hackwar Hackwar deleted the Hackwar:routinginstaller branch Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment