Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing: Discover Itemid in Router for com_newsfeeds #5295

wants to merge 2 commits into from


Copy link

@Hackwar Hackwar commented Dec 2, 2014

This change moves the code that discovers the right Itemid for this content item from the NewsfeedsHelperRoute class into the component router. This means that also URLs in the content get the right Itemid and we don't need to pre-calculate them during the time the item was created. It also means that all URLs are treated correctly and not just those going through NewsfeedsHelperRoute.

This makes NewsfeedsHelperRoute obsolete. The changes that I'm proposing might interfer with PR #5140. So #5140 should be merged first in order to test this one properly. That means that also #5264 and #5276 should be merged before this one.

This touches com_newsfeeds. Further components are done in other PRs. I also wanted to keep it testable, since no one could be expected to test all components at once. See the first PR for this in #5285.

This was made possible through the generous donation of the people mentioned in the following link via an Indiegogo campaign:

Copy link

See my comments on #5285 (comment)

Copy link
Member Author

Hackwar commented Dec 30, 2014

Since this is now superseded by #5444, #5446 and #5503, I'm closing this one.

@Hackwar Hackwar closed this Dec 30, 2014
@Hackwar Hackwar deleted the ItemidInRoutercom_newsfeeds branch December 30, 2014 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants