Fixing notice in categories finder plugin #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested successfully, thank you for the fix, @Hackwar! |
|
Test Ok, Same comment as Hannes here. merging. |
infograf768
added a commit
that referenced
this pull request
Dec 7, 2014
Fixing notice in categories finder plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5313
This fixes a notice when trashing a category and all finder plugins are enabled.
How to test
Thanks @infograf768 for this bug report.
Comment
I honestly don't know what this code should do. I just changed it to remove the notices. However, it seems as if this is not correct the way this is written. It seems to always use the parent categories state for the state of the actual item...