New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing notice in categories finder plugin #5314

Merged
merged 1 commit into from Dec 7, 2014

Conversation

Projects
None yet
5 participants
@Hackwar
Member

Hackwar commented Dec 4, 2014

Fixes #5313

This fixes a notice when trashing a category and all finder plugins are enabled.

How to test

  1. Make sure that all your finder plugins are enabled.
  2. Create a new category in a component of your choice.
  3. Trash that category and see the notice.
  4. Untrash the category.
  5. Apply the patch, trash the category again and see the notices have disappeared.

Thanks @infograf768 for this bug report.

Comment

I honestly don't know what this code should do. I just changed it to remove the notices. However, it seems as if this is not correct the way this is written. It seems to always use the parent categories state for the state of the actual item...

@Kubik-Rubik

This comment has been minimized.

Member

Kubik-Rubik commented Dec 7, 2014

Tested successfully, thank you for the fix, @Hackwar!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5314.

@infograf768

This comment has been minimized.

Member

infograf768 commented Dec 7, 2014

Test Ok, Same comment as Hannes here.
That code was changed in #950

merging.

infograf768 added a commit that referenced this pull request Dec 7, 2014

Merge pull request #5314 from Hackwar/patch-16
Fixing notice in categories finder plugin

@infograf768 infograf768 merged commit 9c91c70 into joomla:staging Dec 7, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@Hackwar Hackwar deleted the Hackwar:patch-16 branch Dec 9, 2014

@Bakual Bakual added this to the Joomla! 3.4.0 milestone Dec 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment