Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFixing notice in categories finder plugin #5314
Conversation
jissues-bot
added
the
PR-staging
label
Dec 4, 2014
infograf768
referenced this pull request
Dec 4, 2014
Closed
Smart Search Notices when trashing a Category #5313
This comment has been minimized.
This comment has been minimized.
|
Tested successfully, thank you for the fix, @Hackwar! |
This comment has been minimized.
This comment has been minimized.
|
Test Ok, Same comment as Hannes here. merging. |
added a commit
that referenced
this pull request
Dec 7, 2014
infograf768
merged commit 9c91c70
into
joomla:staging
Dec 7, 2014
1 check passed
continuous-integration/travis-ci
The Travis CI build passed
Details
Hackwar
deleted the
Hackwar:patch-16
branch
Dec 9, 2014
Bakual
added this to the Joomla! 3.4.0 milestone
Dec 11, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Hackwar commentedDec 4, 2014
Fixes #5313
This fixes a notice when trashing a category and all finder plugins are enabled.
How to test
Thanks @infograf768 for this bug report.
Comment
I honestly don't know what this code should do. I just changed it to remove the notices. However, it seems as if this is not correct the way this is written. It seems to always use the parent categories state for the state of the actual item...