Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JModelAdmin: Batch optimizations #5338

Merged
merged 2 commits into from Dec 10, 2014
Merged

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Dec 7, 2014

This PR optimizes the batch process and removes a lot of duplicate code. It adds 2 new variables that let you define the tasks to do and a copymove task before those additional tasks. That copymove task might modify the IDs of the items to treat and thus needs to be handled differently.

This modification is backwards compatible. To test, please simply check that all batch processes in all combinations still work.

It would be preferable if #5317 would be merged first. This PR is based on those changes and will automatically adapt if #5317 is merged.

@infograf768
Copy link
Member

@infograf768 infograf768 commented Dec 8, 2014

#5317 merged. This PR does not apply anymore here (with eclipse)

…atchoptimizations
@Hackwar
Copy link
Member Author

@Hackwar Hackwar commented Dec 8, 2014

Now it should work. 😉

@smanzi
Copy link

@smanzi smanzi commented Dec 9, 2014

@test success
tested in com_modules and com_content with all options permutations I can think of...

@Kubik-Rubik
Copy link
Member

@Kubik-Rubik Kubik-Rubik commented Dec 10, 2014

Tested successfully!

Thank you, @Hackwar!

Tested batch functions in: Banners, Contact, Menu, Modules and Content

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5338.

@Kubik-Rubik
Copy link
Member

@Kubik-Rubik Kubik-Rubik commented Dec 10, 2014

A side note: The copy function in the batch process for menu entries still doesn't work, the entries are moved, not copied! Can somebody confirm it?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5338.

@Hackwar
Copy link
Member Author

@Hackwar Hackwar commented Dec 10, 2014

Thank you to @smanzi and @Kubik-Rubik

@Hackwar
Copy link
Member Author

@Hackwar Hackwar commented Dec 10, 2014

Just to clarify: That issue with the copy function is unrelated to this PR.

@Kubik-Rubik
Copy link
Member

@Kubik-Rubik Kubik-Rubik commented Dec 10, 2014

Yes, it has nothing to do with this PR! This PR is ready to be committed. 👍

@infograf768
Copy link
Member

@infograf768 infograf768 commented Dec 10, 2014

Works fine here. Merging.

@infograf768 infograf768 added this to the Joomla! 3.4.0 milestone Dec 10, 2014
infograf768 added a commit that referenced this pull request Dec 10, 2014
JModelAdmin: Batch optimizations
@infograf768 infograf768 merged commit b19c06f into joomla:staging Dec 10, 2014
1 check passed
1 check passed
@Hutchy68
continuous-integration/travis-ci The Travis CI build passed
Details
infograf768 added a commit to infograf768/joomla-cms that referenced this pull request Dec 11, 2014
infograf768 added a commit that referenced this pull request Dec 11, 2014
[fix] Adding typealias forgotten in #5338
@Hackwar Hackwar deleted the Hackwar:batchoptimizations branch Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants