New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing tag routing #5347

Merged
merged 1 commit into from Dec 29, 2014

Conversation

Projects
None yet
5 participants
@Hackwar
Member

Hackwar commented Dec 8, 2014

This is an improved and complete fix of #4971. Copying the testing instructions to here:

Steps to reproduce the issue

Install Joomla (Test English (GB) Sample Data), for example
From the backend set the configuration ‘Search Engine Friendly URLs’ = ‘YES’
Use the url: index.php?option=com_tags&view=tag&layout=list&id[0]=3 (not sef url into a sef one. The id can have another value and NO Itemid has to be set)

You will have 3 times the error:
Notice: Array to string conversion in /libraries/cms/router/site.php on line 465

The proposal to fix is to replace
$id = $query['id'];
with
$id = (int) $query['id'];
which seems coherent with the test line 80

Expected result

No error

Actual result

Notice: Array to string conversion in /libraries/cms/router/site.php on line 465

System information (as much as possible)

Joomla 3.3.6

I further cleaned up the router. Basically it should work the same as before, except that that notice is gone. And we have quite a bit less code. 😉

@Hackwar

This comment has been minimized.

Member

Hackwar commented Dec 9, 2014

While this fixes the router up, the TagsHelperRoute class is fixed in #5105. So please have a look there, too. Apply both PRs and it should make a world of difference. 😉

@Hackwar Hackwar referenced this pull request Dec 9, 2014

Closed

Tags: Fixing routing #5105

@chmst

This comment has been minimized.

Contributor

chmst commented Dec 18, 2014

@test - works as described

@bembelimen

This comment has been minimized.

Contributor

bembelimen commented Dec 29, 2014

@test success

@wilsonge

This comment has been minimized.

Contributor

wilsonge commented Dec 29, 2014

@test works for me in various different tags views. Merging

@wilsonge wilsonge added this to the Joomla! 3.4.0 milestone Dec 29, 2014

wilsonge added a commit that referenced this pull request Dec 29, 2014

@wilsonge wilsonge merged commit 88fb6c7 into joomla:staging Dec 29, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@Hackwar Hackwar deleted the Hackwar:tagsrouter branch Dec 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment